mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-15 23:25:07 +00:00
drm/omap: cleanup OMAP_BO_SCANOUT use
omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some reason. It's not clear what the original purpose of OMAP_BO_SCANOUT is, but presuming it means "scanout buffer, something that can be consumed by DSS", this patch cleans up the above issues. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reviewed-by: Jean-Jacques Hiblot <jjhiblot@ti.com> Link: https://patchwork.freedesktop.org/patch/msgid/20191010120000.1421-7-jjhiblot@ti.com
This commit is contained in:
parent
48b34ac041
commit
18d7f5ab54
1 changed files with 2 additions and 4 deletions
|
@ -1155,7 +1155,6 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
|
||||||
* Tiled buffers are always shmem paged backed. When they are
|
* Tiled buffers are always shmem paged backed. When they are
|
||||||
* scanned out, they are remapped into DMM/TILER.
|
* scanned out, they are remapped into DMM/TILER.
|
||||||
*/
|
*/
|
||||||
flags &= ~OMAP_BO_SCANOUT;
|
|
||||||
flags |= OMAP_BO_MEM_SHMEM;
|
flags |= OMAP_BO_MEM_SHMEM;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
@ -1166,9 +1165,8 @@ struct drm_gem_object *omap_gem_new(struct drm_device *dev,
|
||||||
flags |= tiler_get_cpu_cache_flags();
|
flags |= tiler_get_cpu_cache_flags();
|
||||||
} else if ((flags & OMAP_BO_SCANOUT) && !priv->has_dmm) {
|
} else if ((flags & OMAP_BO_SCANOUT) && !priv->has_dmm) {
|
||||||
/*
|
/*
|
||||||
* OMAP_BO_SCANOUT hints that the buffer doesn't need to be
|
* If we don't have DMM, we must allocate scanout buffers
|
||||||
* tiled. However, to lower the pressure on memory allocation,
|
* from contiguous DMA memory.
|
||||||
* use contiguous memory only if no TILER is available.
|
|
||||||
*/
|
*/
|
||||||
flags |= OMAP_BO_MEM_DMA_API;
|
flags |= OMAP_BO_MEM_DMA_API;
|
||||||
} else if (!(flags & OMAP_BO_MEM_DMABUF)) {
|
} else if (!(flags & OMAP_BO_MEM_DMABUF)) {
|
||||||
|
|
Loading…
Reference in a new issue