mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-27 19:29:37 +00:00
Code Issues Releases Wiki Activity

ACPI: use for_each_possible_cpu() instead of for_each_cpu()

Browse source 
for_each_cpu() actually iterates across all possible CPUs.  We've had mistakes
in the past where people were using for_each_cpu() where they should have been
iterating across only online or present CPUs.  This is inefficient and
possibly buggy.

We're renaming for_each_cpu() to for_each_possible_cpu() to avoid this in the
future.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Len Brown <len.brown@intel.com>
This commit is contained in:
KAMEZAWA Hiroyuki 2006-04-27 05:25:00 -04:00 committed by Len Brown
parent 9011bff4bd
commit 193de0c79d
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/acpi/processor_perflib.c
View file

@ -628,7 +628,7 @@ int acpi_processor_preregister_performance(
retval = 0;
/* Call _PSD for all CPUs */
for_each_cpu(i) {
for_each_possible_cpu(i) {
pr = processors[i];
if (!pr) {
/* Look only at processors in ACPI namespace */
@ -659,7 +659,7 @@ int acpi_processor_preregister_performance(
* Now that we have _PSD data from all CPUs, lets setup P-state
* domain info.
*/
for_each_cpu(i) {
for_each_possible_cpu(i) {
pr = processors[i];
if (!pr)
continue;
@ -680,7 +680,7 @@ int acpi_processor_preregister_performance(
}
cpus_clear(covered_cpus);
for_each_cpu(i) {
for_each_possible_cpu(i) {
pr = processors[i];
if (!pr)
continue;
@ -704,7 +704,7 @@ int acpi_processor_preregister_performance(
pr->performance->shared_type = CPUFREQ_SHARED_TYPE_ANY;
}
for_each_cpu(j) {
for_each_possible_cpu(j) {
if (i == j)
continue;
@ -733,7 +733,7 @@ int acpi_processor_preregister_performance(
count++;
}
for_each_cpu(j) {
for_each_possible_cpu(j) {
if (i == j)
continue;
@ -757,7 +757,7 @@ int acpi_processor_preregister_performance(
ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Error while parsing _PSD domain information. Assuming no coordination\n"));
}
for_each_cpu(i) {
for_each_possible_cpu(i) {
pr = processors[i];
if (!pr || !pr->performance)
continue;