mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

fs/ntfs3: Do not use driver own alloc wrappers 

Problem with these wrapper is that we cannot take off example GFP_NOFS
flag. It is not recomended use those in all places. Also if we change
one driver specific wrapper to kernel wrapper then it would look really
weird. People should be most familiar with kernel wrappers so let's just
use those ones.

Driver specific alloc wrapper also confuse some static analyzing tools,
good example is example kernels checkpatch tool. After we converter
these to kernel specific then warnings is showed.

Following Coccinelle script was used to automate changing.

virtual patch

@alloc depends on patch@
expression x;
expression y;
@@
(
-	ntfs_malloc(x)
+	kmalloc(x, GFP_NOFS)
|
-	ntfs_zalloc(x)
+	kzalloc(x, GFP_NOFS)
|
-	ntfs_vmalloc(x)
+	kvmalloc(x, GFP_NOFS)
|
-	ntfs_free(x)
+	kfree(x)
|
-	ntfs_vfree(x)
+	kvfree(x)
|
-	ntfs_memdup(x, y)
+	kmemdup(x, y, GFP_NOFS)
)

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
This commit is contained in:
Kari Argillander 2021-08-24 21:37:07 +03:00 committed by Konstantin Komarov
parent fa3cacf544
commit 195c52bdd5
No known key found for this signature in database
GPG Key ID: A9B0331F832407B6
16 changed files with 188 additions and 194 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/ntfs3/attrib.c
View File

@ -276,7 +276,7 @@ int attr_make_nonresident(struct ntfs_inode *ni, struct ATTRIB *attr,
run_init(run);
/* make a copy of original attribute */
attr_s = ntfs_memdup(attr, asize);
attr_s = kmemdup(attr, asize, GFP_NOFS);
if (!attr_s) {
err = -ENOMEM;
goto out;
@ -333,7 +333,7 @@ int attr_make_nonresident(struct ntfs_inode *ni, struct ATTRIB *attr,
if (err)
goto out3;
ntfs_free(attr_s);
kfree(attr_s);
attr->nres.data_size = cpu_to_le64(rsize);
attr->nres.valid_size = attr->nres.data_size;
@ -356,7 +356,7 @@ out2:
run_deallocate(sbi, run, false);
run_close(run);
out1:
ntfs_free(attr_s);
kfree(attr_s);
/*reinsert le*/
out:
return err;

10
fs/ntfs3/attrlist.c
View File

@ -28,7 +28,7 @@ static inline bool al_is_valid_le(const struct ntfs_inode *ni,
void al_destroy(struct ntfs_inode *ni)
{
run_close(&ni->attr_list.run);
ntfs_free(ni->attr_list.le);
kfree(ni->attr_list.le);
ni->attr_list.le = NULL;
ni->attr_list.size = 0;
ni->attr_list.dirty = false;
@ -51,7 +51,7 @@ int ntfs_load_attr_list(struct ntfs_inode *ni, struct ATTRIB *attr)
if (!attr->non_res) {
lsize = le32_to_cpu(attr->res.data_size);
le = ntfs_malloc(al_aligned(lsize));
le = kmalloc(al_aligned(lsize), GFP_NOFS);
if (!le) {
err = -ENOMEM;
goto out;
@ -74,7 +74,7 @@ int ntfs_load_attr_list(struct ntfs_inode *ni, struct ATTRIB *attr)
if (err < 0)
goto out;
le = ntfs_malloc(al_aligned(lsize));
le = kmalloc(al_aligned(lsize), GFP_NOFS);
if (!le) {
err = -ENOMEM;
goto out;
@ -289,7 +289,7 @@ int al_add_le(struct ntfs_inode *ni, enum ATTR_TYPE type, const __le16 *name,
off = PtrOffset(al->le, le);
if (new_size > asize) {
void *ptr = ntfs_malloc(new_asize);
void *ptr = kmalloc(new_asize, GFP_NOFS);
if (!ptr)
return -ENOMEM;
@ -297,7 +297,7 @@ int al_add_le(struct ntfs_inode *ni, enum ATTR_TYPE type, const __le16 *name,
memcpy(ptr, al->le, off);
memcpy(Add2Ptr(ptr, off + sz), le, al->size - off);
le = Add2Ptr(ptr, off);
ntfs_free(al->le);
kfree(al->le);
al->le = ptr;
} else {
memmove(Add2Ptr(le, sz), le, al->size - off);

8
fs/ntfs3/bitmap.c
View File

@ -133,7 +133,7 @@ void wnd_close(struct wnd_bitmap *wnd)
{
struct rb_node *node, *next;
ntfs_free(wnd->free_bits);
kfree(wnd->free_bits);
run_close(&wnd->run);
node = rb_first(&wnd->start_tree);
@ -683,7 +683,7 @@ int wnd_init(struct wnd_bitmap *wnd, struct super_block *sb, size_t nbits)
if (!wnd->bits_last)
wnd->bits_last = wbits;
wnd->free_bits = ntfs_zalloc(wnd->nwnd * sizeof(u16));
wnd->free_bits = kzalloc(wnd->nwnd * sizeof(u16), GFP_NOFS);
if (!wnd->free_bits)
return -ENOMEM;
@ -1354,7 +1354,7 @@ int wnd_extend(struct wnd_bitmap *wnd, size_t new_bits)
new_last = wbits;
if (new_wnd != wnd->nwnd) {
new_free = ntfs_malloc(new_wnd * sizeof(u16));
new_free = kmalloc(new_wnd * sizeof(u16), GFP_NOFS);
if (!new_free)
return -ENOMEM;
@ -1363,7 +1363,7 @@ int wnd_extend(struct wnd_bitmap *wnd, size_t new_bits)
wnd->nwnd * sizeof(short));
memset(new_free + wnd->nwnd, 0,
(new_wnd - wnd->nwnd) * sizeof(short));
ntfs_free(wnd->free_bits);
kfree(wnd->free_bits);
wnd->free_bits = new_free;
}

7
fs/ntfs3/debug.h
View File

@ -47,12 +47,5 @@ void ntfs_inode_printk(struct inode *inode, const char *fmt, ...)
#define ntfs_inode_warn(inode, fmt, ...) \
ntfs_inode_printk(inode, KERN_WARNING fmt, ##__VA_ARGS__)
#define ntfs_malloc(s) kmalloc(s, GFP_NOFS)
#define ntfs_zalloc(s) kzalloc(s, GFP_NOFS)
#define ntfs_vmalloc(s) kvmalloc(s, GFP_KERNEL)
#define ntfs_free(p) kfree(p)
#define ntfs_vfree(p) kvfree(p)
#define ntfs_memdup(src, len) kmemdup(src, len, GFP_NOFS)
#endif /* _LINUX_NTFS3_DEBUG_H */
// clang-format on

4
fs/ntfs3/file.c
View File

@ -900,7 +900,7 @@ static ssize_t ntfs_compress_write(struct kiocb *iocb, struct iov_iter *from)
return -EOPNOTSUPP;
}
pages = ntfs_malloc(pages_per_frame * sizeof(struct page *));
pages = kmalloc(pages_per_frame * sizeof(struct page *), GFP_NOFS);
if (!pages)
return -ENOMEM;
@ -1076,7 +1076,7 @@ static ssize_t ntfs_compress_write(struct kiocb *iocb, struct iov_iter *from)
}
out:
ntfs_free(pages);
kfree(pages);
current->backing_dev_info = NULL;

27
fs/ntfs3/frecord.c
View File

@ -388,7 +388,7 @@ bool ni_add_subrecord(struct ntfs_inode *ni, CLST rno, struct mft_inode **mi)
{
struct mft_inode *m;
m = ntfs_zalloc(sizeof(struct mft_inode));
m = kzalloc(sizeof(struct mft_inode), GFP_NOFS);
if (!m)
return false;
@ -752,7 +752,7 @@ static int ni_try_remove_attr_list(struct ntfs_inode *ni)
run_deallocate(sbi, &ni->attr_list.run, true);
run_close(&ni->attr_list.run);
ni->attr_list.size = 0;
ntfs_free(ni->attr_list.le);
kfree(ni->attr_list.le);
ni->attr_list.le = NULL;
ni->attr_list.dirty = false;
@ -787,7 +787,7 @@ int ni_create_attr_list(struct ntfs_inode *ni)
* Skip estimating exact memory requirement
* Looks like one record_size is always enough
*/
le = ntfs_malloc(al_aligned(rs));
le = kmalloc(al_aligned(rs), GFP_NOFS);
if (!le) {
err = -ENOMEM;
goto out;
@ -893,7 +893,7 @@ int ni_create_attr_list(struct ntfs_inode *ni)
goto out;
out1:
ntfs_free(ni->attr_list.le);
kfree(ni->attr_list.le);
ni->attr_list.le = NULL;
ni->attr_list.size = 0;
@ -2054,7 +2054,7 @@ int ni_readpage_cmpr(struct ntfs_inode *ni, struct page *page)
idx = (vbo - frame_vbo) >> PAGE_SHIFT;
pages_per_frame = frame_size >> PAGE_SHIFT;
pages = ntfs_zalloc(pages_per_frame * sizeof(struct page *));
pages = kzalloc(pages_per_frame * sizeof(struct page *), GFP_NOFS);
if (!pages) {
err = -ENOMEM;
goto out;
@ -2092,7 +2092,7 @@ out1:
out:
/* At this point, err contains 0 or -EIO depending on the "critical" page */
ntfs_free(pages);
kfree(pages);
unlock_page(page);
return err;
@ -2137,7 +2137,7 @@ int ni_decompress_file(struct ntfs_inode *ni)
frame_bits = ni_ext_compress_bits(ni);
frame_size = 1u << frame_bits;
pages_per_frame = frame_size >> PAGE_SHIFT;
pages = ntfs_zalloc(pages_per_frame * sizeof(struct page *));
pages = kzalloc(pages_per_frame * sizeof(struct page *), GFP_NOFS);
if (!pages) {
err = -ENOMEM;
goto out;
@ -2298,7 +2298,7 @@ remove_wof:
mapping->a_ops = &ntfs_aops;
out:
ntfs_free(pages);
kfree(pages);
if (err) {
make_bad_inode(inode);
ntfs_set_state(sbi, NTFS_DIRTY_ERROR);
@ -2564,7 +2564,7 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages,
goto out1;
}
pages_disk = ntfs_zalloc(npages_disk * sizeof(struct page *));
pages_disk = kzalloc(npages_disk * sizeof(struct page *), GFP_NOFS);
if (!pages_disk) {
err = -ENOMEM;
goto out2;
@ -2633,7 +2633,7 @@ out3:
put_page(pg);
}
}
ntfs_free(pages_disk);
kfree(pages_disk);
out2:
#ifdef CONFIG_NTFS3_LZX_XPRESS
@ -2709,7 +2709,8 @@ int ni_write_frame(struct ntfs_inode *ni, struct page **pages,
goto out;
}
pages_disk = ntfs_zalloc(pages_per_frame * sizeof(struct page *));
pages_disk = kzalloc(pages_per_frame * sizeof(struct page *),
GFP_NOFS);
if (!pages_disk) {
err = -ENOMEM;
goto out;
@ -2769,7 +2770,7 @@ int ni_write_frame(struct ntfs_inode *ni, struct page **pages,
compr_size = compress_lznt(frame_mem, frame_size, frame_ondisk,
frame_size, sbi->compress.lznt);
mutex_unlock(&sbi->compress.mtx_lznt);
ntfs_free(lznt);
kfree(lznt);
if (compr_size + sbi->cluster_size > frame_size) {
/* frame is not compressed */
@ -2818,7 +2819,7 @@ out1:
put_page(pg);
}
}
ntfs_free(pages_disk);
kfree(pages_disk);
out:
return err;
}

172
fs/ntfs3/fslog.c
View File

@ -406,9 +406,9 @@ struct lcb {
static void lcb_put(struct lcb *lcb)
{
if (lcb->alloc)
ntfs_free(lcb->log_rec);
ntfs_free(lcb->lrh);
ntfs_free(lcb);
kfree(lcb->log_rec);
kfree(lcb->lrh);
kfree(lcb);
}
/*
@ -807,7 +807,7 @@ static inline struct RESTART_TABLE *init_rsttbl(u16 esize, u16 used)
u32 off;
u32 bytes = esize * used + sizeof(struct RESTART_TABLE);
u32 lf = sizeof(struct RESTART_TABLE) + (used - 1) * esize;
struct RESTART_TABLE *t = ntfs_zalloc(bytes);
struct RESTART_TABLE *t = kzalloc(bytes, GFP_NOFS);
t->size = cpu_to_le16(esize);
t->used = cpu_to_le16(used);
@ -849,7 +849,7 @@ static inline struct RESTART_TABLE *extend_rsttbl(struct RESTART_TABLE *tbl,
rt->total = tbl->total;
ntfs_free(tbl);
kfree(tbl);
return rt;
}
@ -1134,7 +1134,7 @@ static int read_log_page(struct ntfs_log *log, u32 vbo,
return -EINVAL;
if (!*buffer) {
to_free = ntfs_malloc(bytes);
to_free = kmalloc(bytes, GFP_NOFS);
if (!to_free)
return -ENOMEM;
*buffer = to_free;
@ -1164,7 +1164,7 @@ static int read_log_page(struct ntfs_log *log, u32 vbo,
out:
if (err && to_free) {
ntfs_free(to_free);
kfree(to_free);
*buffer = NULL;
}
@ -1181,7 +1181,7 @@ static int log_read_rst(struct ntfs_log *log, u32 l_size, bool first,
struct restart_info *info)
{
u32 skip, vbo;
struct RESTART_HDR *r_page = ntfs_malloc(DefaultLogPageSize);
struct RESTART_HDR *r_page = kmalloc(DefaultLogPageSize, GFP_NOFS);
if (!r_page)
return -ENOMEM;
@ -1257,8 +1257,8 @@ static int log_read_rst(struct ntfs_log *log, u32 l_size, bool first,
/* Read the entire restart area */
sys_page_size = le32_to_cpu(r_page->sys_page_size);
if (DefaultLogPageSize != sys_page_size) {
ntfs_free(r_page);
r_page = ntfs_zalloc(sys_page_size);
kfree(r_page);
r_page = kzalloc(sys_page_size, GFP_NOFS);
if (!r_page)
return -ENOMEM;
@ -1266,7 +1266,7 @@ static int log_read_rst(struct ntfs_log *log, u32 l_size, bool first,
(struct RECORD_PAGE_HDR **)&r_page,
&usa_error)) {
/* ignore any errors */
ntfs_free(r_page);
kfree(r_page);
r_page = NULL;
continue;
}
@ -1296,7 +1296,7 @@ check_result:
}
}
ntfs_free(r_page);
kfree(r_page);
return 0;
}
@ -1397,7 +1397,7 @@ static void log_create(struct ntfs_log *log, u32 l_size, const u64 last_lsn,
static struct RESTART_AREA *log_create_ra(struct ntfs_log *log)
{
struct CLIENT_REC *cr;
struct RESTART_AREA *ra = ntfs_zalloc(log->restart_size);
struct RESTART_AREA *ra = kzalloc(log->restart_size, GFP_NOFS);
if (!ra)
return NULL;
@ -1509,7 +1509,7 @@ static int next_log_lsn(struct ntfs_log *log, const struct LFS_RECORD_HDR *rh,
if (!is_lsn_in_file(log, *lsn))
*lsn = 0;
ntfs_free(page);
kfree(page);
return 0;
}
@ -1634,7 +1634,7 @@ static int last_log_lsn(struct ntfs_log *log)
second_off = 0x12 * log->page_size;
// 0x10 == 0x12 - 0x2
page_bufs = ntfs_malloc(log->page_size * 0x10);
page_bufs = kmalloc(log->page_size * 0x10, GFP_NOFS);
if (!page_bufs)
return -ENOMEM;
} else {
@ -1646,7 +1646,7 @@ next_tail:
/* Read second tail page (at pos 3/0x12000) */
if (read_log_page(log, second_off, &second_tail, &usa_error) ||
usa_error || second_tail->rhdr.sign != NTFS_RCRD_SIGNATURE) {
ntfs_free(second_tail);
kfree(second_tail);
second_tail = NULL;
second_file_off = 0;
lsn2 = 0;
@ -1658,7 +1658,7 @@ next_tail:
/* Read first tail page (at pos 2/0x2000 ) */
if (read_log_page(log, final_off, &first_tail, &usa_error) ||
usa_error || first_tail->rhdr.sign != NTFS_RCRD_SIGNATURE) {
ntfs_free(first_tail);
kfree(first_tail);
first_tail = NULL;
first_file_off = 0;
lsn1 = 0;
@ -1759,17 +1759,17 @@ next_tail:
page_pos = page_cnt = 1;
}
} else {
ntfs_free(first_tail);
ntfs_free(second_tail);
kfree(first_tail);
kfree(second_tail);
goto tail_read;
}
ntfs_free(first_tail_prev);
kfree(first_tail_prev);
first_tail_prev = first_tail;
final_off_prev = first_file_off;
first_tail = NULL;
ntfs_free(second_tail_prev);
kfree(second_tail_prev);
second_tail_prev = second_tail;
second_off_prev = second_file_off;
second_tail = NULL;
@ -2030,7 +2030,7 @@ next_page_1:
}
curpage_off = nextpage_off;
ntfs_free(page);
kfree(page);
page = NULL;
reuse_page = 0;
goto next_page;
@ -2092,7 +2092,7 @@ check_tail:
cur_pos = 2;
next_test_page:
ntfs_free(tst_page);
kfree(tst_page);
tst_page = NULL;
/* Walk through the file, reading log pages */
@ -2151,7 +2151,7 @@ check_valid:
}
/* Call our routine to check this log page */
ntfs_free(tst_page);
kfree(tst_page);
tst_page = NULL;
err = read_log_page(log, nextpage_off, &tst_page, &usa_error);
@ -2186,7 +2186,7 @@ file_is_valid:
u64 off = hdr_file_off(log, tmp_page);
if (!page) {
page = ntfs_malloc(log->page_size);
page = kmalloc(log->page_size, GFP_NOFS);
if (!page)
return -ENOMEM;
}
@ -2231,11 +2231,11 @@ file_is_valid:
}
out:
ntfs_free(second_tail);
ntfs_free(first_tail);
ntfs_free(page);
ntfs_free(tst_page);
ntfs_free(page_bufs);
kfree(second_tail);
kfree(first_tail);
kfree(page);
kfree(tst_page);
kfree(page_bufs);
return err;
}
@ -2311,7 +2311,7 @@ static int read_log_rec_buf(struct ntfs_log *log,
}
out:
ntfs_free(ph);
kfree(ph);
return err;
}
@ -2360,7 +2360,7 @@ static int read_rst_area(struct ntfs_log *log, struct NTFS_RESTART **rst_,
goto out;
}
rst = ntfs_malloc(len);
rst = kmalloc(len, GFP_NOFS);
if (!rst) {
err = -ENOMEM;
goto out;
@ -2375,8 +2375,8 @@ static int read_rst_area(struct ntfs_log *log, struct NTFS_RESTART **rst_,
rst = NULL;
out:
ntfs_free(rh);
ntfs_free(rst);
kfree(rh);
kfree(rst);
return err;
}
@ -2419,7 +2419,7 @@ static int find_log_rec(struct ntfs_log *log, u64 lsn, struct lcb *lcb)
* put a pointer to the log record the context block
*/
if (rh->flags & LOG_RECORD_MULTI_PAGE) {
void *lr = ntfs_malloc(len);
void *lr = kmalloc(len, GFP_NOFS);
if (!lr)
return -ENOMEM;
@ -2472,7 +2472,7 @@ static int read_log_rec_lcb(struct ntfs_log *log, u64 lsn, u32 ctx_mode,
if (!verify_client_lsn(log, cr, lsn))
return -EINVAL;
lcb = ntfs_zalloc(sizeof(struct lcb));
lcb = kzalloc(sizeof(struct lcb), GFP_NOFS);
if (!lcb)
return -ENOMEM;
lcb->client = log->client_id;
@ -2521,7 +2521,7 @@ static int find_client_next_lsn(struct ntfs_log *log, struct lcb *lcb, u64 *lsn)
break;
if (hdr != lcb->lrh)
ntfs_free(hdr);
kfree(hdr);
hdr = NULL;
err = read_log_page(log, lsn_to_vbo(log, current_lsn),
@ -2533,7 +2533,7 @@ static int find_client_next_lsn(struct ntfs_log *log, struct lcb *lcb, u64 *lsn)
sizeof(struct CLIENT_ID))) {
/*err = -EINVAL; */
} else if (LfsClientRecord == hdr->record_type) {
ntfs_free(lcb->lrh);
kfree(lcb->lrh);
lcb->lrh = hdr;
*lsn = current_lsn;
return 0;
@ -2542,7 +2542,7 @@ static int find_client_next_lsn(struct ntfs_log *log, struct lcb *lcb, u64 *lsn)
out:
if (hdr != lcb->lrh)
ntfs_free(hdr);
kfree(hdr);
return err;
check_undo_next:
@ -2566,7 +2566,7 @@ check_undo_next:
(struct RECORD_PAGE_HDR **)&hdr, NULL);
if (err)
return err;
ntfs_free(lcb->lrh);
kfree(lcb->lrh);
lcb->lrh = hdr;
*lsn = next_lsn;
@ -2586,11 +2586,11 @@ static int read_next_log_rec(struct ntfs_log *log, struct lcb *lcb, u64 *lsn)
return 0;
if (lcb->alloc)
ntfs_free(lcb->log_rec);
kfree(lcb->log_rec);
lcb->log_rec = NULL;
lcb->alloc = false;
ntfs_free(lcb->lrh);
kfree(lcb->lrh);
lcb->lrh = NULL;
return find_log_rec(log, *lsn, lcb);
@ -2987,7 +2987,7 @@ static struct ATTRIB *attr_create_nonres_log(struct ntfs_sb_info *sbi,
u32 asize = name_size +
(is_ext ? SIZEOF_NONRESIDENT_EX : SIZEOF_NONRESIDENT);
attr = ntfs_zalloc(asize);
attr = kzalloc(asize, GFP_NOFS);
if (!attr)
return NULL;
@ -3087,7 +3087,7 @@ static int do_action(struct ntfs_log *log, struct OPEN_ATTR_ENRTY *oe,
if (inode) {
mi = &ntfs_i(inode)->mi;
} else if (op == InitializeFileRecordSegment) {
mi = ntfs_zalloc(sizeof(struct mft_inode));
mi = kzalloc(sizeof(struct mft_inode), GFP_NOFS);
if (!mi)
return -ENOMEM;
err = mi_format_new(mi, sbi, rno, 0, false);
@ -3181,7 +3181,7 @@ skip_load_parent:
if (attr->type == ATTR_ALLOC)
bytes = (bytes + 511) & ~511; // align
buffer_le = ntfs_malloc(bytes);
buffer_le = kmalloc(bytes, GFP_NOFS);
if (!buffer_le)
return -ENOMEM;
@ -3250,11 +3250,11 @@ skip_load_parent:
oa2 = find_loaded_attr(log, attr, rno_base);
if (oa2) {
void *p2 = ntfs_memdup(attr, le32_to_cpu(attr->size));
void *p2 = kmemdup(attr, le32_to_cpu(attr->size),
GFP_NOFS);
if (p2) {
// run_close(oa2->run1);
ntfs_free(oa2->attr);
kfree(oa2->attr);
oa2->attr = p2;
}
}
@ -3317,12 +3317,12 @@ move_data:
oa2 = find_loaded_attr(log, attr, rno_base);
if (oa2) {
void *p2 = ntfs_memdup(attr, le32_to_cpu(attr->size));
void *p2 = kmemdup(attr, le32_to_cpu(attr->size),
GFP_NOFS);
if (p2) {
// run_close(&oa2->run0);
oa2->run1 = &oa2->run0;
ntfs_free(oa2->attr);
kfree(oa2->attr);
oa2->attr = p2;
}
}
@ -3376,10 +3376,10 @@ move_data:
oa2 = find_loaded_attr(log, attr, rno_base);
if (oa2) {
void *p2 = ntfs_memdup(attr, le32_to_cpu(attr->size));
void *p2 = kmemdup(attr, le32_to_cpu(attr->size),
GFP_NOFS);
if (p2) {
ntfs_free(oa2->attr);
kfree(oa2->attr);
oa2->attr = p2;
}
}
@ -3714,7 +3714,7 @@ out:
else if (mi != mi2_child)
mi_put(mi);
ntfs_free(buffer_le);
kfree(buffer_le);
return err;
@ -3783,13 +3783,13 @@ int log_replay(struct ntfs_inode *ni, bool *initialized)
if (!page_size)
return -EINVAL;
log = ntfs_zalloc(sizeof(struct ntfs_log));
log = kzalloc(sizeof(struct ntfs_log), GFP_NOFS);
if (!log)
return -ENOMEM;
log->ni = ni;
log->l_size = l_size;
log->one_page_buf = ntfs_malloc(page_size);
log->one_page_buf = kmalloc(page_size, GFP_NOFS);
if (!log->one_page_buf) {
err = -ENOMEM;
@ -3854,17 +3854,17 @@ int log_replay(struct ntfs_inode *ni, bool *initialized)
sp->rhdr.sign == NTFS_CHKD_SIGNATURE) {
use_second_page = false;
}
ntfs_free(sp);
kfree(sp);
}
if (use_second_page) {
ntfs_free(rst_info.r_page);
kfree(rst_info.r_page);
memcpy(&rst_info, &rst_info2, sizeof(struct restart_info));
rst_info2.r_page = NULL;
}
use_first_page:
ntfs_free(rst_info2.r_page);
kfree(rst_info2.r_page);
check_restart_area:
/* If the restart area is at offset 0, we want to write the second restart area first */
@ -4012,7 +4012,7 @@ find_oldest:
log->current_avail = current_log_avail(log);
ra = ntfs_zalloc(log->restart_size);
ra = kzalloc(log->restart_size, GFP_NOFS);
if (!ra) {
err = -ENOMEM;
goto out;
@ -4147,7 +4147,7 @@ process_log:
goto out;
}
trtbl = ntfs_memdup(rt, t32);
trtbl = kmemdup(rt, t32, GFP_NOFS);
if (!trtbl) {
err = -ENOMEM;
goto out;
@ -4187,7 +4187,7 @@ check_dirty_page_table:
goto out;
}
dptbl = ntfs_memdup(rt, t32);
dptbl = kmemdup(rt, t32, GFP_NOFS);
if (!dptbl) {
err = -ENOMEM;
goto out;
@ -4254,7 +4254,7 @@ check_attribute_names:
t32 = lrh_length(lrh);
rec_len -= t32;
attr_names = ntfs_memdup(Add2Ptr(lrh, t32), rec_len);
attr_names = kmemdup(Add2Ptr(lrh, t32), rec_len, GFP_NOFS);
lcb_put(lcb);
lcb = NULL;
@ -4289,7 +4289,7 @@ check_attr_table:
goto out;
}
oatbl = ntfs_memdup(rt, t32);
oatbl = kmemdup(rt, t32, GFP_NOFS);
if (!oatbl) {
err = -ENOMEM;
goto out;
@ -4472,7 +4472,7 @@ next_log_record_analyze:
sizeof(u64);
} else {
t32 = log->clst_per_page;
ntfs_free(dptbl);
kfree(dptbl);
dptbl = init_rsttbl(struct_size(dp, page_lcns, t32),
32);
if (!dptbl) {
@ -4575,7 +4575,7 @@ copy_lcns:
t16 = le16_to_cpu(lrh->undo_len);
if (t16) {
oe->ptr = ntfs_malloc(t16);
oe->ptr = kmalloc(t16, GFP_NOFS);
if (!oe->ptr) {
err = -ENOMEM;
goto out;
@ -4680,7 +4680,7 @@ next_open_attribute:
goto next_dirty_page;
}
oa = ntfs_zalloc(sizeof(struct OpenAttr));
oa = kzalloc(sizeof(struct OpenAttr), GFP_NOFS);
if (!oa) {
err = -ENOMEM;
goto out;
@ -4701,7 +4701,7 @@ fake_attr:
attr = attr_create_nonres_log(sbi, oe->type, 0, oe->ptr,
oe->name_len, 0);
if (!attr) {
ntfs_free(oa);
kfree(oa);
err = -ENOMEM;
goto out;
}
@ -4720,7 +4720,7 @@ fake_attr:
goto fake_attr;
t32 = le32_to_cpu(attr->size);
oa->attr = ntfs_memdup(attr, t32);
oa->attr = kmemdup(attr, t32, GFP_NOFS);
if (!oa->attr)
goto fake_attr;
@ -4746,7 +4746,7 @@ fake_attr:
le64_to_cpu(attr->nres.evcn), svcn,
Add2Ptr(attr, roff), t32 - roff);
if (err < 0) {
ntfs_free(oa->attr);
kfree(oa->attr);
oa->attr = NULL;
goto fake_attr;
}
@ -4757,7 +4757,7 @@ fake_attr:
final_oe:
if (oe->is_attr_name == 1)
ntfs_free(oe->ptr);
kfree(oe->ptr);
oe->is_attr_name = 0;
oe->ptr = oa;
oe->name_len = attr->name_len;
@ -5090,7 +5090,7 @@ end_reply:
if (is_ro)
goto out;
rh = ntfs_zalloc(log->page_size);
rh = kzalloc(log->page_size, GFP_NOFS);
if (!rh) {
err = -ENOMEM;
goto out;
@ -5125,12 +5125,12 @@ end_reply:
err = ntfs_sb_write_run(sbi, &log->ni->file.run, log->page_size,
rh, log->page_size);
ntfs_free(rh);
kfree(rh);
if (err)
goto out;
out:
ntfs_free(rst);
kfree(rst);
if (lcb)
lcb_put(lcb);
@ -5140,7 +5140,7 @@ out:
rno = ino_get(&oe->ref);
if (oe->is_attr_name == 1) {
ntfs_free(oe->ptr);
kfree(oe->ptr);
oe->ptr = NULL;
continue;
}
@ -5153,20 +5153,20 @@ out:
continue;
run_close(&oa->run0);
ntfs_free(oa->attr);
kfree(oa->attr);
if (oa->ni)
iput(&oa->ni->vfs_inode);
ntfs_free(oa);
kfree(oa);
}
ntfs_free(trtbl);
ntfs_free(oatbl);
ntfs_free(dptbl);
ntfs_free(attr_names);
ntfs_free(rst_info.r_page);
kfree(trtbl);
kfree(oatbl);
kfree(dptbl);
kfree(attr_names);
kfree(rst_info.r_page);
ntfs_free(ra);
ntfs_free(log->one_page_buf);
kfree(ra);
kfree(log->one_page_buf);
if (err)
sbi->flags |= NTFS_FLAGS_NEED_REPLAY;
@ -5176,7 +5176,7 @@ out:
else if (log->set_dirty)
ntfs_set_state(sbi, NTFS_DIRTY_ERROR);
ntfs_free(log);
kfree(log);
return err;
}

8
fs/ntfs3/fsntfs.c
View File

@ -2035,7 +2035,7 @@ int ntfs_get_security_by_id(struct ntfs_sb_info *sbi, __le32 security_id,
*size = t32 - SIZEOF_SECURITY_HDR;
p = ntfs_malloc(*size);
p = kmalloc(*size, GFP_NOFS);
if (!p) {
err = -ENOMEM;
goto out;
@ -2063,7 +2063,7 @@ int ntfs_get_security_by_id(struct ntfs_sb_info *sbi, __le32 security_id,
p = NULL;
out:
ntfs_free(p);
kfree(p);
fnd_put(fnd_sii);
ni_unlock(ni);
@ -2115,7 +2115,7 @@ int ntfs_insert_security(struct ntfs_sb_info *sbi,
*security_id = SECURITY_ID_INVALID;
/* Allocate a temporal buffer*/
d_security = ntfs_zalloc(aligned_sec_size);
d_security = kzalloc(aligned_sec_size, GFP_NOFS);
if (!d_security)
return -ENOMEM;
@ -2279,7 +2279,7 @@ out:
fnd_put(fnd_sdh);
mark_inode_dirty(&ni->vfs_inode);
ni_unlock(ni);
ntfs_free(d_security);
kfree(d_security);
return err;
}

54
fs/ntfs3/index.c
View File

@ -682,7 +682,7 @@ static struct NTFS_DE *hdr_find_e(const struct ntfs_index *indx,
if (end > 0x10000)
goto next;
offs = ntfs_malloc(sizeof(u16) * nslots);
offs = kmalloc(sizeof(u16) * nslots, GFP_NOFS);
if (!offs)
goto next;
@ -704,10 +704,10 @@ next1:
u16 *ptr;
int new_slots = ALIGN(2 * nslots, 8);
ptr = ntfs_malloc(sizeof(u16) * new_slots);
ptr = kmalloc(sizeof(u16) * new_slots, GFP_NOFS);
if (ptr)
memcpy(ptr, offs, sizeof(u16) * max_idx);
ntfs_free(offs);
kfree(offs);
offs = ptr;
nslots = new_slots;
if (!ptr)
@ -764,7 +764,7 @@ next1:
e = Add2Ptr(hdr, offs[fnd]);
out1:
ntfs_free(offs);
kfree(offs);
return e;
#endif
@ -934,21 +934,21 @@ static struct indx_node *indx_new(struct ntfs_index *indx,
u16 fn;
u32 eo;
r = ntfs_zalloc(sizeof(struct indx_node));
r = kzalloc(sizeof(struct indx_node), GFP_NOFS);
if (!r)
return ERR_PTR(-ENOMEM);
index = ntfs_zalloc(bytes);
index = kzalloc(bytes, GFP_NOFS);
if (!index) {
ntfs_free(r);
kfree(r);
return ERR_PTR(-ENOMEM);
}
err = ntfs_get_bh(ni->mi.sbi, &indx->alloc_run, vbo, bytes, &r->nb);
if (err) {
ntfs_free(index);
ntfs_free(r);
kfree(index);
kfree(r);
return ERR_PTR(err);
}
@ -1027,7 +1027,7 @@ int indx_read(struct ntfs_index *indx, struct ntfs_inode *ni, CLST vbn,
const struct INDEX_NAMES *name;
if (!in) {
in = ntfs_zalloc(sizeof(struct indx_node));
in = kzalloc(sizeof(struct indx_node), GFP_NOFS);
if (!in)
return -ENOMEM;
} else {
@ -1036,7 +1036,7 @@ int indx_read(struct ntfs_index *indx, struct ntfs_inode *ni, CLST vbn,
ib = in->index;
if (!ib) {
ib = ntfs_malloc(bytes);
ib = kmalloc(bytes, GFP_NOFS);
if (!ib) {
err = -ENOMEM;
goto out;
@ -1083,11 +1083,11 @@ ok:
out:
if (ib != in->index)
ntfs_free(ib);
kfree(ib);
if (*node != in) {
nb_put(&in->nb);
ntfs_free(in);
kfree(in);
}
return err;
@ -1219,7 +1219,7 @@ next_iter:
sizeof(struct NTFS_DE) + sizeof(u64)) {
if (n) {
fnd_pop(fnd);
ntfs_free(n);
kfree(n);
}
return -EINVAL;
}
@ -1232,7 +1232,7 @@ next_iter:
/* Try next level */
e = hdr_first_de(&n->index->ihdr);
if (!e) {
ntfs_free(n);
kfree(n);
return -EINVAL;
}
@ -1252,7 +1252,7 @@ pop_level:
/* Pop one level */
if (n) {
fnd_pop(fnd);
ntfs_free(n);
kfree(n);
}
level = fnd->level;
@ -1589,7 +1589,7 @@ static int indx_insert_into_root(struct ntfs_index *indx, struct ntfs_inode *ni,
}
/* Make a copy of root attribute to restore if error */
a_root = ntfs_memdup(attr, asize);
a_root = kmemdup(attr, asize, GFP_NOFS);
if (!a_root) {
err = -ENOMEM;
goto out;
@ -1615,7 +1615,7 @@ static int indx_insert_into_root(struct ntfs_index *indx, struct ntfs_inode *ni,
if (!to_move) {
re = NULL;
} else {
re = ntfs_memdup(e0, to_move);
re = kmemdup(e0, to_move, GFP_NOFS);
if (!re) {
err = -ENOMEM;
goto out;
@ -1708,7 +1708,7 @@ static int indx_insert_into_root(struct ntfs_index *indx, struct ntfs_inode *ni,
* new entry classic case when mft record is 1K and index
* buffer 4K the problem should not occurs
*/
ntfs_free(re);
kfree(re);
indx_write(indx, ni, n, 0);
put_indx_node(n);
@ -1734,12 +1734,12 @@ static int indx_insert_into_root(struct ntfs_index *indx, struct ntfs_inode *ni,
n = NULL;
out1:
ntfs_free(re);
kfree(re);
if (n)
put_indx_node(n);
out:
ntfs_free(a_root);
kfree(a_root);
return err;
}
@ -1792,7 +1792,7 @@ indx_insert_into_buffer(struct ntfs_index *indx, struct ntfs_inode *ni,
return -EINVAL;
sp_size = le16_to_cpu(sp->size);
up_e = ntfs_malloc(sp_size + sizeof(u64));
up_e = kmalloc(sp_size + sizeof(u64), GFP_NOFS);
if (!up_e)
return -ENOMEM;
memcpy(up_e, sp, sp_size);
@ -1870,7 +1870,7 @@ indx_insert_into_buffer(struct ntfs_index *indx, struct ntfs_inode *ni,
}
out:
ntfs_free(up_e);
kfree(up_e);
return err;
}
@ -2149,7 +2149,7 @@ static int indx_get_entry_to_replace(struct ntfs_index *indx,
n = fnd->nodes[level];
te = hdr_first_de(&n->index->ihdr);
/* Copy the candidate entry into the replacement entry buffer. */
re = ntfs_malloc(le16_to_cpu(te->size) + sizeof(u64));
re = kmalloc(le16_to_cpu(te->size) + sizeof(u64), GFP_NOFS);
if (!re) {
err = -ENOMEM;
goto out;
@ -2301,7 +2301,7 @@ int indx_delete_entry(struct ntfs_index *indx, struct ntfs_inode *ni,
fnd)
: indx_insert_into_root(indx, ni, re, e,
ctx, fnd);
ntfs_free(re);
kfree(re);
if (err)
goto out;
@ -2459,7 +2459,7 @@ int indx_delete_entry(struct ntfs_index *indx, struct ntfs_inode *ni,
* as appropriate.
*/
e_size = le16_to_cpu(e->size);
me = ntfs_memdup(e, e_size);
me = kmemdup(e, e_size, GFP_NOFS);
if (!me) {
err = -ENOMEM;
goto out;
@ -2505,7 +2505,7 @@ int indx_delete_entry(struct ntfs_index *indx, struct ntfs_inode *ni,
* Find the spot the tree where we want to insert the new entry.
*/
err = indx_insert_entry(indx, ni, me, ctx, fnd);
ntfs_free(me);
kfree(me);
if (err)
goto out;

10
fs/ntfs3/inode.c
View File

@ -1096,7 +1096,7 @@ ntfs_create_reparse_buffer(struct ntfs_sb_info *sbi, const char *symname,
__le16 *rp_name;
typeof(rp->SymbolicLinkReparseBuffer) *rs;
rp = ntfs_zalloc(ntfs_reparse_bytes(2 * size + 2));
rp = kzalloc(ntfs_reparse_bytes(2 * size + 2), GFP_NOFS);
if (!rp)
return ERR_PTR(-ENOMEM);
@ -1151,7 +1151,7 @@ ntfs_create_reparse_buffer(struct ntfs_sb_info *sbi, const char *symname,
return rp;
out:
ntfs_free(rp);
kfree(rp);
return ERR_PTR(err);
}
@ -1619,7 +1619,7 @@ out3:
out2:
__putname(new_de);
ntfs_free(rp);
kfree(rp);
out1:
if (err)
@ -1862,7 +1862,7 @@ static noinline int ntfs_readlink_hlp(struct inode *inode, char *buffer,
goto out;
}
} else {
rp = ntfs_malloc(i_size);
rp = kmalloc(i_size, GFP_NOFS);
if (!rp) {
err = -ENOMEM;
goto out;
@ -1972,7 +1972,7 @@ static noinline int ntfs_readlink_hlp(struct inode *inode, char *buffer,
/* Always set last zero */
buffer[err] = 0;
out:
ntfs_free(to_free);
kfree(to_free);
return err;
}

4
fs/ntfs3/lznt.c
View File

@ -294,8 +294,8 @@ next:
*/
struct lznt *get_lznt_ctx(int level)
{
struct lznt *r = ntfs_zalloc(level ? offsetof(struct lznt, hash)
: sizeof(struct lznt));
struct lznt *r = kzalloc(level ? offsetof(struct lznt, hash) :
sizeof(struct lznt), GFP_NOFS);
if (r)
r->std = !level;

18
fs/ntfs3/ntfs_fs.h
View File

@ -603,13 +603,13 @@ int indx_used_bit(struct ntfs_index *indx, struct ntfs_inode *ni, size_t *bit);
void fnd_clear(struct ntfs_fnd *fnd);
static inline struct ntfs_fnd *fnd_get(void)
{
return ntfs_zalloc(sizeof(struct ntfs_fnd));
return kzalloc(sizeof(struct ntfs_fnd), GFP_NOFS);
}
static inline void fnd_put(struct ntfs_fnd *fnd)
{
if (fnd) {
fnd_clear(fnd);
ntfs_free(fnd);
kfree(fnd);
}
}
void indx_clear(struct ntfs_index *idx);
@ -875,20 +875,20 @@ static inline void run_init(struct runs_tree *run)
static inline struct runs_tree *run_alloc(void)
{
return ntfs_zalloc(sizeof(struct runs_tree));
return kzalloc(sizeof(struct runs_tree), GFP_NOFS);
}
static inline void run_close(struct runs_tree *run)
{
ntfs_vfree(run->runs);
kvfree(run->runs);
memset(run, 0, sizeof(*run));
}
static inline void run_free(struct runs_tree *run)
{
if (run) {
ntfs_vfree(run->runs);
ntfs_free(run);
kvfree(run->runs);
kfree(run);
}
}
@ -1044,15 +1044,15 @@ static inline void put_indx_node(struct indx_node *in)
if (!in)
return;
ntfs_free(in->index);
kfree(in->index);
nb_put(&in->nb);
ntfs_free(in);
kfree(in);
}
static inline void mi_clear(struct mft_inode *mi)
{
nb_put(&mi->nb);
ntfs_free(mi->mrec);
kfree(mi->mrec);
mi->mrec = NULL;
}

8
fs/ntfs3/record.c
View File

@ -76,14 +76,14 @@ static __le16 mi_new_attt_id(struct mft_inode *mi)
int mi_get(struct ntfs_sb_info *sbi, CLST rno, struct mft_inode **mi)
{
int err;
struct mft_inode *m = ntfs_zalloc(sizeof(struct mft_inode));
struct mft_inode *m = kzalloc(sizeof(struct mft_inode), GFP_NOFS);
if (!m)
return -ENOMEM;
err = mi_init(m, sbi, rno);
if (err) {
ntfs_free(m);
kfree(m);
return err;
}
@ -100,14 +100,14 @@ int mi_get(struct ntfs_sb_info *sbi, CLST rno, struct mft_inode **mi)
void mi_put(struct mft_inode *mi)
{
mi_clear(mi);
ntfs_free(mi);
kfree(mi);
}
int mi_init(struct mft_inode *mi, struct ntfs_sb_info *sbi, CLST rno)
{
mi->sbi = sbi;
mi->rno = rno;
mi->mrec = ntfs_malloc(sbi->record_size);
mi->mrec = kmalloc(sbi->record_size, GFP_NOFS);
if (!mi->mrec)
return -ENOMEM;

8
fs/ntfs3/run.c
View File

@ -254,7 +254,7 @@ void run_truncate_head(struct runs_tree *run, CLST vcn)
run->count -= index;
if (!run->count) {
ntfs_vfree(run->runs);
kvfree(run->runs);
run->runs = NULL;
run->allocated = 0;
}
@ -293,7 +293,7 @@ void run_truncate(struct runs_tree *run, CLST vcn)
/* Do not reallocate array 'runs'. Only free if possible */
if (!index) {
ntfs_vfree(run->runs);
kvfree(run->runs);
run->runs = NULL;
run->allocated = 0;
}
@ -388,7 +388,7 @@ requires_new_range:
WARN_ON(!is_mft && bytes > NTFS3_RUN_MAX_BYTES);
new_ptr = ntfs_vmalloc(bytes);
new_ptr = kvmalloc(bytes, GFP_KERNEL);
if (!new_ptr)
return false;
@ -399,7 +399,7 @@ requires_new_range:
memcpy(r + 1, run->runs + index,
sizeof(struct ntfs_run) * (run->count - index));
ntfs_vfree(run->runs);
kvfree(run->runs);
run->runs = new_ptr;
run->allocated = bytes;

20
fs/ntfs3/super.c
View File

@ -468,9 +468,9 @@ static void init_once(void *foo)
/* noinline to reduce binary size*/
static noinline void put_ntfs(struct ntfs_sb_info *sbi)
{
ntfs_free(sbi->new_rec);
ntfs_vfree(ntfs_put_shared(sbi->upcase));
ntfs_free(sbi->def_table);
kfree(sbi->new_rec);
kvfree(ntfs_put_shared(sbi->upcase));
kfree(sbi->def_table);
wnd_close(&sbi->mft.bitmap);
wnd_close(&sbi->used.bitmap);
@ -496,14 +496,14 @@ static noinline void put_ntfs(struct ntfs_sb_info *sbi)
indx_clear(&sbi->security.index_sdh);
indx_clear(&sbi->reparse.index_r);
indx_clear(&sbi->objid.index_o);
ntfs_free(sbi->compress.lznt);
kfree(sbi->compress.lznt);
#ifdef CONFIG_NTFS3_LZX_XPRESS
xpress_free_decompressor(sbi->compress.xpress);
lzx_free_decompressor(sbi->compress.lzx);
#endif
clear_mount_options(&sbi->options);
ntfs_free(sbi);
kfree(sbi);
}
static void ntfs_put_super(struct super_block *sb)
@ -848,7 +848,7 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
sbi->used.bitmap.nbits = clusters;
rec = ntfs_zalloc(record_size);
rec = kzalloc(record_size, GFP_NOFS);
if (!rec) {
err = -ENOMEM;
goto out;
@ -915,7 +915,7 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
ref.high = 0;
sbi = ntfs_zalloc(sizeof(struct ntfs_sb_info));
sbi = kzalloc(sizeof(struct ntfs_sb_info), GFP_NOFS);
if (!sbi)
return -ENOMEM;
@ -1181,7 +1181,7 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
goto out;
}
bytes = inode->i_size;
sbi->def_table = t = ntfs_malloc(bytes);
sbi->def_table = t = kmalloc(bytes, GFP_NOFS);
if (!t) {
err = -ENOMEM;
goto out;
@ -1247,7 +1247,7 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
goto out;
}
sbi->upcase = upcase = ntfs_vmalloc(0x10000 * sizeof(short));
sbi->upcase = upcase = kvmalloc(0x10000 * sizeof(short), GFP_KERNEL);
if (!upcase) {
err = -ENOMEM;
goto out;
@ -1277,7 +1277,7 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
shared = ntfs_set_shared(upcase, 0x10000 * sizeof(short));
if (shared && upcase != shared) {
sbi->upcase = shared;
ntfs_vfree(upcase);
kvfree(upcase);
}
iput(inode);

18
fs/ntfs3/xattr.c
View File

@ -110,7 +110,7 @@ static int ntfs_read_ea(struct ntfs_inode *ni, struct EA_FULL **ea,
return -EFBIG;
/* Allocate memory for packed Ea */
ea_p = ntfs_malloc(size + add_bytes);
ea_p = kmalloc(size + add_bytes, GFP_NOFS);
if (!ea_p)
return -ENOMEM;
@ -142,7 +142,7 @@ static int ntfs_read_ea(struct ntfs_inode *ni, struct EA_FULL **ea,
return 0;
out:
ntfs_free(ea_p);
kfree(ea_p);
*ea = NULL;
return err;
}
@ -193,7 +193,7 @@ static ssize_t ntfs_list_ea(struct ntfs_inode *ni, char *buffer,
}
out:
ntfs_free(ea_all);
kfree(ea_all);
return err ? err : ret;
}
@ -251,7 +251,7 @@ static int ntfs_get_ea(struct inode *inode, const char *name, size_t name_len,
err = 0;
out:
ntfs_free(ea_all);
kfree(ea_all);
if (!required)
ni_unlock(ni);
@ -352,7 +352,7 @@ static noinline int ntfs_set_ea(struct inode *inode, const char *name,
}
if (!ea_all) {
ea_all = ntfs_zalloc(add);
ea_all = kzalloc(add, GFP_NOFS);
if (!ea_all) {
err = -ENOMEM;
goto out;
@ -474,7 +474,7 @@ out:
ni_unlock(ni);
run_close(&ea_run);
ntfs_free(ea_all);
kfree(ea_all);
return err;
}
@ -599,7 +599,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
value = NULL;
} else {
size = posix_acl_xattr_size(acl->a_count);
value = ntfs_malloc(size);
value = kmalloc(size, GFP_NOFS);
if (!value)
return -ENOMEM;
@ -614,7 +614,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
set_cached_acl(inode, type, acl);
out:
ntfs_free(value);
kfree(value);
return err;
}
@ -880,7 +880,7 @@ static int ntfs_getxattr(const struct xattr_handler *handler, struct dentry *de,
err = sd_size;
memcpy(buffer, sd, sd_size);
}
ntfs_free(sd);
kfree(sd);
goto out;
}