mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 06:33:07 +00:00
[NET_SCHED]: cls_u32: remove unnecessary NULL-ptr check
In both cases n can't be NULL without crashing anyway. Coverity #78 Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
a5cdc03003
commit
1ae39a430b
1 changed files with 2 additions and 4 deletions
|
@ -347,8 +347,7 @@ static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n)
|
||||||
if (n->ht_down)
|
if (n->ht_down)
|
||||||
n->ht_down->refcnt--;
|
n->ht_down->refcnt--;
|
||||||
#ifdef CONFIG_CLS_U32_PERF
|
#ifdef CONFIG_CLS_U32_PERF
|
||||||
if (n)
|
kfree(n->pf);
|
||||||
kfree(n->pf);
|
|
||||||
#endif
|
#endif
|
||||||
kfree(n);
|
kfree(n);
|
||||||
return 0;
|
return 0;
|
||||||
|
@ -680,8 +679,7 @@ static int u32_change(struct tcf_proto *tp, unsigned long base, u32 handle,
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
#ifdef CONFIG_CLS_U32_PERF
|
#ifdef CONFIG_CLS_U32_PERF
|
||||||
if (n)
|
kfree(n->pf);
|
||||||
kfree(n->pf);
|
|
||||||
#endif
|
#endif
|
||||||
kfree(n);
|
kfree(n);
|
||||||
return err;
|
return err;
|
||||||
|
|
Loading…
Reference in a new issue