mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 20:02:17 +00:00
media: mceusb: Fix potential out-of-bounds shift
When processing a MCE_RSP_GETPORTSTATUS command, the bit index to set in ir->txports_cabled comes from response data, and isn't validated. As ir->txports_cabled is a u8, nothing should be done if the bit index is greater than 7. Cc: stable@vger.kernel.org Reported-by: syzbot+ec3b3128c576e109171d@syzkaller.appspotmail.com Signed-off-by: James Reynolds <jr@memlen.com> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
4487e02155
commit
1b43bad31f
1 changed files with 1 additions and 1 deletions
|
@ -1169,7 +1169,7 @@ static void mceusb_handle_command(struct mceusb_dev *ir, u8 *buf_in)
|
|||
switch (subcmd) {
|
||||
/* the one and only 5-byte return value command */
|
||||
case MCE_RSP_GETPORTSTATUS:
|
||||
if (buf_in[5] == 0)
|
||||
if (buf_in[5] == 0 && *hi < 8)
|
||||
ir->txports_cabled |= 1 << *hi;
|
||||
break;
|
||||
|
||||
|
|
Loading…
Reference in a new issue