mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-16 07:35:14 +00:00
mlxsw: spectrum_router: Fix error handling issue
Return error to the caller instead of suppressing it.
Fixes: e3ddfb45ba
("mlxsw: spectrum_router: Allow returning errors from mlxsw_sp_nexthop_group_refresh()")
Addresses-Coverity: ("Error handling issues (CHECKED_RETURN)")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
4be074e6dd
commit
1c2c5eb6e1
1 changed files with 2 additions and 4 deletions
|
@ -3608,10 +3608,8 @@ mlxsw_sp_nexthop_group_refresh(struct mlxsw_sp *mlxsw_sp,
|
|||
int i, err2, err = 0;
|
||||
u32 old_adj_index;
|
||||
|
||||
if (!nhgi->gateway) {
|
||||
mlxsw_sp_nexthop_fib_entries_update(mlxsw_sp, nh_grp);
|
||||
return 0;
|
||||
}
|
||||
if (!nhgi->gateway)
|
||||
return mlxsw_sp_nexthop_fib_entries_update(mlxsw_sp, nh_grp);
|
||||
|
||||
for (i = 0; i < nhgi->count; i++) {
|
||||
nh = &nhgi->nexthops[i];
|
||||
|
|
Loading…
Reference in a new issue