mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 07:38:10 +00:00
scsi: lpfc: fix kzalloc-simple.cocci warnings
drivers/scsi/lpfc/lpfc_debugfs.c:5460:22-29: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset drivers/scsi/lpfc/lpfc_debugfs.c:2230:20-27: WARNING: kzalloc should be used for phba -> nvmeio_trc, instead of kmalloc/memset Use kzalloc rather than kmalloc followed by memset with 0 Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> Acked-by: James Smart <james.smart@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
62d2f77438
commit
1c356ec5e9
1 changed files with 2 additions and 7 deletions
|
@ -2227,7 +2227,7 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf,
|
||||||
kfree(phba->nvmeio_trc);
|
kfree(phba->nvmeio_trc);
|
||||||
|
|
||||||
/* Allocate new trace buffer and initialize */
|
/* Allocate new trace buffer and initialize */
|
||||||
phba->nvmeio_trc = kmalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) *
|
phba->nvmeio_trc = kzalloc((sizeof(struct lpfc_debugfs_nvmeio_trc) *
|
||||||
sz), GFP_KERNEL);
|
sz), GFP_KERNEL);
|
||||||
if (!phba->nvmeio_trc) {
|
if (!phba->nvmeio_trc) {
|
||||||
lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
|
lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
|
||||||
|
@ -2235,8 +2235,6 @@ lpfc_debugfs_nvmeio_trc_write(struct file *file, const char __user *buf,
|
||||||
"nvmeio_trc buffer\n");
|
"nvmeio_trc buffer\n");
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
}
|
}
|
||||||
memset(phba->nvmeio_trc, 0,
|
|
||||||
(sizeof(struct lpfc_debugfs_nvmeio_trc) * sz));
|
|
||||||
atomic_set(&phba->nvmeio_trc_cnt, 0);
|
atomic_set(&phba->nvmeio_trc_cnt, 0);
|
||||||
phba->nvmeio_trc_on = 0;
|
phba->nvmeio_trc_on = 0;
|
||||||
phba->nvmeio_trc_output_idx = 0;
|
phba->nvmeio_trc_output_idx = 0;
|
||||||
|
@ -5457,7 +5455,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
|
||||||
phba->nvmeio_trc_size = lpfc_debugfs_max_nvmeio_trc;
|
phba->nvmeio_trc_size = lpfc_debugfs_max_nvmeio_trc;
|
||||||
|
|
||||||
/* Allocate trace buffer and initialize */
|
/* Allocate trace buffer and initialize */
|
||||||
phba->nvmeio_trc = kmalloc(
|
phba->nvmeio_trc = kzalloc(
|
||||||
(sizeof(struct lpfc_debugfs_nvmeio_trc) *
|
(sizeof(struct lpfc_debugfs_nvmeio_trc) *
|
||||||
phba->nvmeio_trc_size), GFP_KERNEL);
|
phba->nvmeio_trc_size), GFP_KERNEL);
|
||||||
|
|
||||||
|
@ -5467,9 +5465,6 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
|
||||||
"nvmeio_trc buffer\n");
|
"nvmeio_trc buffer\n");
|
||||||
goto nvmeio_off;
|
goto nvmeio_off;
|
||||||
}
|
}
|
||||||
memset(phba->nvmeio_trc, 0,
|
|
||||||
(sizeof(struct lpfc_debugfs_nvmeio_trc) *
|
|
||||||
phba->nvmeio_trc_size));
|
|
||||||
phba->nvmeio_trc_on = 1;
|
phba->nvmeio_trc_on = 1;
|
||||||
phba->nvmeio_trc_output_idx = 0;
|
phba->nvmeio_trc_output_idx = 0;
|
||||||
phba->nvmeio_trc = NULL;
|
phba->nvmeio_trc = NULL;
|
||||||
|
|
Loading…
Reference in a new issue