modpost: Fix processing of CRCs on 32-bit build machines
commitfb27e70f6e
upstream. modpost now reads CRCs from .*.cmd files, parsing them using strtol(). This is inconsistent with its parsing of Module.symvers and with their definition as *unsigned* 32-bit values. strtol() clamps values to [LONG_MIN, LONG_MAX], and when building on a 32-bit system this changes all CRCs >= 0x80000000 to be 0x7fffffff. Change extract_crcs_for_object() to use strtoul() instead. Cc: stable@vger.kernel.org Fixes:f292d875d0
("modpost: extract symbol versions from *.cmd files") Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
95a4b9270e
commit
1ecf0875ac
|
@ -1733,7 +1733,7 @@ static void extract_crcs_for_object(const char *object, struct module *mod)
|
|||
if (!isdigit(*p))
|
||||
continue; /* skip this line */
|
||||
|
||||
crc = strtol(p, &p, 0);
|
||||
crc = strtoul(p, &p, 0);
|
||||
if (*p != '\n')
|
||||
continue; /* skip this line */
|
||||
|
||||
|
|
Loading…
Reference in New Issue