mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
media: cedrus: Improve error messages for controls
Currently error messages when control creation fails are very sparse. Granted, user should never observe them. However, developer working on codecs can. In such cases additional information like which control creation failed and error number are very useful. Expand error messages with additional info. Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
parent
f1a413902a
commit
1f258653e1
1 changed files with 5 additions and 2 deletions
|
@ -242,7 +242,8 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx)
|
|||
v4l2_ctrl_handler_init(hdl, CEDRUS_CONTROLS_COUNT);
|
||||
if (hdl->error) {
|
||||
v4l2_err(&dev->v4l2_dev,
|
||||
"Failed to initialize control handler\n");
|
||||
"Failed to initialize control handler: %d\n",
|
||||
hdl->error);
|
||||
return hdl->error;
|
||||
}
|
||||
|
||||
|
@ -257,7 +258,9 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx)
|
|||
NULL);
|
||||
if (hdl->error) {
|
||||
v4l2_err(&dev->v4l2_dev,
|
||||
"Failed to create new custom control\n");
|
||||
"Failed to create %s control: %d\n",
|
||||
v4l2_ctrl_get_name(cedrus_controls[i].cfg.id),
|
||||
hdl->error);
|
||||
|
||||
v4l2_ctrl_handler_free(hdl);
|
||||
kfree(ctx->ctrls);
|
||||
|
|
Loading…
Reference in a new issue