mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-21 16:29:59 +00:00
mtd: atmel_nand: move the sanity check to the beginning of pmecc_enable()
It is better to do the sanity check for the parameter before any hardware operation. Signed-off-by: Josh Wu <josh.wu@atmel.com> Signed-off-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
parent
e09f7f9928
commit
1fad0e8b9a
1 changed files with 4 additions and 4 deletions
|
@ -905,15 +905,15 @@ static void pmecc_enable(struct atmel_nand_host *host, int ecc_op)
|
|||
{
|
||||
u32 val;
|
||||
|
||||
pmecc_writel(host->ecc, CTRL, PMECC_CTRL_RST);
|
||||
pmecc_writel(host->ecc, CTRL, PMECC_CTRL_DISABLE);
|
||||
val = pmecc_readl_relaxed(host->ecc, CFG);
|
||||
|
||||
if (ecc_op != NAND_ECC_READ && ecc_op != NAND_ECC_WRITE) {
|
||||
dev_err(host->dev, "atmel_nand: wrong pmecc operation type!");
|
||||
return;
|
||||
}
|
||||
|
||||
pmecc_writel(host->ecc, CTRL, PMECC_CTRL_RST);
|
||||
pmecc_writel(host->ecc, CTRL, PMECC_CTRL_DISABLE);
|
||||
val = pmecc_readl_relaxed(host->ecc, CFG);
|
||||
|
||||
if (ecc_op == NAND_ECC_READ)
|
||||
pmecc_writel(host->ecc, CFG, (val & ~PMECC_CFG_WRITE_OP)
|
||||
| PMECC_CFG_AUTO_ENABLE);
|
||||
|
|
Loading…
Reference in a new issue