From 1fe428d3692fb10a0e8d85fafe719b154e43ad4e Mon Sep 17 00:00:00 2001 From: Rick Edgecombe Date: Thu, 24 Aug 2023 18:45:54 -0700 Subject: [PATCH] x86/shstk: Change order of __user in type 0day reports a sparse warning: arch/x86/kernel/shstk.c:295:55: sparse: sparse: cast removes address space '__user' of expression The __user is in the wrong spot. Move it to right spot and make sparse happy. Closes: https://lore.kernel.org/oe-kbuild-all/202308222312.Jt4Tog5T-lkp@intel.com/ Reported-by: kernel test robot Signed-off-by: Rick Edgecombe Signed-off-by: Dave Hansen Link: https://lore.kernel.org/all/20230825014554.1769194-1-rick.p.edgecombe%40intel.com --- arch/x86/kernel/shstk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/shstk.c b/arch/x86/kernel/shstk.c index cd10d074a444..fd689921a1db 100644 --- a/arch/x86/kernel/shstk.c +++ b/arch/x86/kernel/shstk.c @@ -275,7 +275,7 @@ static int shstk_push_sigframe(unsigned long *ssp) return -EINVAL; *ssp -= SS_FRAME_SIZE; - if (put_shstk_data((void *__user)*ssp, target_ssp)) + if (put_shstk_data((void __user *)*ssp, target_ssp)) return -EFAULT; return 0;