mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-22 17:01:14 +00:00
media: ao-cec-g12a: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
parent
45848b2834
commit
202779456d
1 changed files with 2 additions and 4 deletions
|
@ -744,7 +744,7 @@ static int meson_ao_cec_g12a_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int meson_ao_cec_g12a_remove(struct platform_device *pdev)
|
||||
static void meson_ao_cec_g12a_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct meson_ao_cec_g12a_device *ao_cec = platform_get_drvdata(pdev);
|
||||
|
||||
|
@ -753,8 +753,6 @@ static int meson_ao_cec_g12a_remove(struct platform_device *pdev)
|
|||
cec_notifier_cec_adap_unregister(ao_cec->notify, ao_cec->adap);
|
||||
|
||||
cec_unregister_adapter(ao_cec->adap);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct meson_ao_cec_g12a_data ao_cec_g12a_data = {
|
||||
|
@ -780,7 +778,7 @@ MODULE_DEVICE_TABLE(of, meson_ao_cec_g12a_of_match);
|
|||
|
||||
static struct platform_driver meson_ao_cec_g12a_driver = {
|
||||
.probe = meson_ao_cec_g12a_probe,
|
||||
.remove = meson_ao_cec_g12a_remove,
|
||||
.remove_new = meson_ao_cec_g12a_remove,
|
||||
.driver = {
|
||||
.name = "meson-ao-cec-g12a",
|
||||
.of_match_table = of_match_ptr(meson_ao_cec_g12a_of_match),
|
||||
|
|
Loading…
Reference in a new issue