mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 18:09:57 +00:00
[PATCH] hwmon: w83627hf: no reset by default
Make the reset of the chips in w83627hf optional rather than the default. This reset has been causing trouble several times already. It may even go completely away unless it proves to be useful to at least one user. Closes bug #5168: http://bugzilla.kernel.org/show_bug.cgi?id=5168 Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
0db9714a0c
commit
2251cf1a4b
1 changed files with 13 additions and 1 deletions
|
@ -64,6 +64,10 @@ static unsigned short address;
|
||||||
/* Insmod parameters */
|
/* Insmod parameters */
|
||||||
enum chips { any_chip, w83627hf, w83627thf, w83697hf, w83637hf };
|
enum chips { any_chip, w83627hf, w83627thf, w83697hf, w83637hf };
|
||||||
|
|
||||||
|
static int reset;
|
||||||
|
module_param(reset, bool, 0);
|
||||||
|
MODULE_PARM_DESC(reset, "Set to one to reset chip on load");
|
||||||
|
|
||||||
static int init = 1;
|
static int init = 1;
|
||||||
module_param(init, bool, 0);
|
module_param(init, bool, 0);
|
||||||
MODULE_PARM_DESC(init, "Set to zero to bypass chip initialization");
|
MODULE_PARM_DESC(init, "Set to zero to bypass chip initialization");
|
||||||
|
@ -1279,7 +1283,15 @@ static void w83627hf_init_client(struct i2c_client *client)
|
||||||
int type = data->type;
|
int type = data->type;
|
||||||
u8 tmp;
|
u8 tmp;
|
||||||
|
|
||||||
if(init) {
|
if (reset) {
|
||||||
|
/* Resetting the chip has been the default for a long time,
|
||||||
|
but repeatedly caused problems (fans going to full
|
||||||
|
speed...) so it is now optional. It might even go away if
|
||||||
|
nobody reports it as being useful, as I see very little
|
||||||
|
reason why this would be needed at all. */
|
||||||
|
dev_info(&client->dev, "If reset=1 solved a problem you were "
|
||||||
|
"having, please report!\n");
|
||||||
|
|
||||||
/* save this register */
|
/* save this register */
|
||||||
i = w83627hf_read_value(client, W83781D_REG_BEEP_CONFIG);
|
i = w83627hf_read_value(client, W83781D_REG_BEEP_CONFIG);
|
||||||
/* Reset all except Watchdog values and last conversion values
|
/* Reset all except Watchdog values and last conversion values
|
||||||
|
|
Loading…
Reference in a new issue