mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
uml: use of a public MAC is a warning, not an error
Downgrade one of the MAC validity checks. If it's one that could be possibly assigned to a physical NIC, then nothing will break. So, emit a warning in this case, but keep the requested MAC. Signed-off-by: Jeff Dike <jdike@linux.intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
cc0be0fb3f
commit
2278c5ac9d
1 changed files with 4 additions and 5 deletions
|
@ -318,7 +318,7 @@ static void setup_etheraddr(char *str, unsigned char *addr, char *name)
|
|||
if (str == NULL)
|
||||
goto random;
|
||||
|
||||
for (i = 0;i < 6; i++) {
|
||||
for (i = 0; i < 6; i++) {
|
||||
addr[i] = simple_strtoul(str, &end, 16);
|
||||
if ((end == str) ||
|
||||
((*end != ':') && (*end != ',') && (*end != '\0'))) {
|
||||
|
@ -343,14 +343,13 @@ static void setup_etheraddr(char *str, unsigned char *addr, char *name)
|
|||
}
|
||||
if (!is_local_ether_addr(addr)) {
|
||||
printk(KERN_WARNING
|
||||
"Warning: attempt to assign a globally valid ethernet "
|
||||
"Warning: Assigning a globally valid ethernet "
|
||||
"address to a device\n");
|
||||
printk(KERN_WARNING "You should better enable the 2nd "
|
||||
"rightmost bit in the first byte of the MAC,\n");
|
||||
printk(KERN_WARNING "You should set the 2nd rightmost bit in "
|
||||
"the first byte of the MAC,\n");
|
||||
printk(KERN_WARNING "i.e. %02x:%02x:%02x:%02x:%02x:%02x\n",
|
||||
addr[0] | 0x02, addr[1], addr[2], addr[3], addr[4],
|
||||
addr[5]);
|
||||
goto random;
|
||||
}
|
||||
return;
|
||||
|
||||
|
|
Loading…
Reference in a new issue