mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-16 07:35:14 +00:00
backlight: lm3630a: Fix return code of .update_status() callback
[ Upstream commit b9481a667a
]
According to <linux/backlight.h> .update_status() is supposed to
return 0 on success and a negative error code otherwise. Adapt
lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status() to
actually do it.
While touching that also add the error code to the failure message.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
b15f3cad6f
commit
22ecd1ef4f
1 changed files with 6 additions and 6 deletions
|
@ -184,7 +184,7 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
|
|||
if ((pwm_ctrl & LM3630A_PWM_BANK_A) != 0) {
|
||||
lm3630a_pwm_ctrl(pchip, bl->props.brightness,
|
||||
bl->props.max_brightness);
|
||||
return bl->props.brightness;
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* disable sleep */
|
||||
|
@ -204,8 +204,8 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
|
|||
return 0;
|
||||
|
||||
out_i2c_err:
|
||||
dev_err(pchip->dev, "i2c failed to access\n");
|
||||
return bl->props.brightness;
|
||||
dev_err(pchip->dev, "i2c failed to access (%pe)\n", ERR_PTR(ret));
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int lm3630a_bank_a_get_brightness(struct backlight_device *bl)
|
||||
|
@ -261,7 +261,7 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
|
|||
if ((pwm_ctrl & LM3630A_PWM_BANK_B) != 0) {
|
||||
lm3630a_pwm_ctrl(pchip, bl->props.brightness,
|
||||
bl->props.max_brightness);
|
||||
return bl->props.brightness;
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* disable sleep */
|
||||
|
@ -281,8 +281,8 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
|
|||
return 0;
|
||||
|
||||
out_i2c_err:
|
||||
dev_err(pchip->dev, "i2c failed to access REG_CTRL\n");
|
||||
return bl->props.brightness;
|
||||
dev_err(pchip->dev, "i2c failed to access (%pe)\n", ERR_PTR(ret));
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int lm3630a_bank_b_get_brightness(struct backlight_device *bl)
|
||||
|
|
Loading…
Reference in a new issue