mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
staging/easycap: fix mismatch in easycap_poll() mutex lock-unlock
In case if condition (kd != isdongle(peasycap)) becomes true, easycap_poll() returns without releasing easycapdc60_dongle[kd].mutex_video. The patch adds mutex_unlock() before that return. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Acked-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
0f18f767e5
commit
22f88fcf40
1 changed files with 3 additions and 1 deletions
|
@ -953,8 +953,10 @@ static unsigned int easycap_poll(struct file *file, poll_table *wait)
|
|||
* peasycap, IN WHICH CASE A REPEAT CALL TO isdongle() WILL FAIL.
|
||||
* IF NECESSARY, BAIL OUT.
|
||||
*/
|
||||
if (kd != isdongle(peasycap))
|
||||
if (kd != isdongle(peasycap)) {
|
||||
mutex_unlock(&easycapdc60_dongle[kd].mutex_video);
|
||||
return -ERESTARTSYS;
|
||||
}
|
||||
if (!file) {
|
||||
SAY("ERROR: file is NULL\n");
|
||||
mutex_unlock(&easycapdc60_dongle[kd].mutex_video);
|
||||
|
|
Loading…
Reference in a new issue