mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-16 07:35:14 +00:00
thermal/drivers/cpufreq_cooling: Update cpufreq_state only if state has changed
If state has not changed successfully and we updated cpufreq_state,
next time when the new state is equal to cpufreq_state (not changed
successfully last time), we will return directly and miss a
freq_qos_update_request() that should have been.
Fixes: 5130802ddb
("thermal: cpu_cooling: Switch to QoS requests for freq limits")
Cc: v5.4+ <stable@vger.kernel.org> # v5.4+
Signed-off-by: Zhuguangqing <zhuguangqing@xiaomi.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201106092243.15574-1-zhuguangqing83@gmail.com
This commit is contained in:
parent
030a48b0f6
commit
236761f19a
1 changed files with 1 additions and 3 deletions
|
@ -438,13 +438,11 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev,
|
||||||
if (cpufreq_cdev->cpufreq_state == state)
|
if (cpufreq_cdev->cpufreq_state == state)
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
cpufreq_cdev->cpufreq_state = state;
|
|
||||||
|
|
||||||
frequency = get_state_freq(cpufreq_cdev, state);
|
frequency = get_state_freq(cpufreq_cdev, state);
|
||||||
|
|
||||||
ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency);
|
ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency);
|
||||||
|
|
||||||
if (ret > 0) {
|
if (ret > 0) {
|
||||||
|
cpufreq_cdev->cpufreq_state = state;
|
||||||
cpus = cpufreq_cdev->policy->cpus;
|
cpus = cpufreq_cdev->policy->cpus;
|
||||||
max_capacity = arch_scale_cpu_capacity(cpumask_first(cpus));
|
max_capacity = arch_scale_cpu_capacity(cpumask_first(cpus));
|
||||||
capacity = frequency * max_capacity;
|
capacity = frequency * max_capacity;
|
||||||
|
|
Loading…
Reference in a new issue