mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 09:59:32 +00:00
sfc: Use correct macro to set event bitfield
falcon_sim_phy_event() used EFX_OWORD_FIELD, which operates on bitfields in 128-bit values, on an event, which is a 64-bit value. This should be harmless - these macros always use little-endian ordering, so it would read and write back the following 8 bytes unchanged - but it is obviously wrong. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
718cff1eec
commit
239795adf7
1 changed files with 2 additions and 2 deletions
|
@ -1176,9 +1176,9 @@ void falcon_sim_phy_event(struct efx_nic *efx)
|
|||
|
||||
EFX_POPULATE_QWORD_1(phy_event, EV_CODE, GLOBAL_EV_DECODE);
|
||||
if (EFX_IS10G(efx))
|
||||
EFX_SET_OWORD_FIELD(phy_event, XG_PHY_INTR, 1);
|
||||
EFX_SET_QWORD_FIELD(phy_event, XG_PHY_INTR, 1);
|
||||
else
|
||||
EFX_SET_OWORD_FIELD(phy_event, G_PHY0_INTR, 1);
|
||||
EFX_SET_QWORD_FIELD(phy_event, G_PHY0_INTR, 1);
|
||||
|
||||
falcon_generate_event(&efx->channel[0], &phy_event);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue