mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
i2c: cadence: fix reference leak when pm_runtime_get_sync fails
The PM reference count is not expected to be incremented on
return in functions cdns_i2c_master_xfer and cdns_reg_slave.
However, pm_runtime_get_sync will increment pm usage counter
even failed. Forgetting to putting operation will result in a
reference leak here.
Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.
Fixes: 7fa32329ca
("i2c: cadence: Move to sensible power management")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
parent
d5c1d60697
commit
23ceb8462d
1 changed files with 2 additions and 2 deletions
|
@ -789,7 +789,7 @@ static int cdns_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
|
||||||
bool change_role = false;
|
bool change_role = false;
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
ret = pm_runtime_get_sync(id->dev);
|
ret = pm_runtime_resume_and_get(id->dev);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
return ret;
|
return ret;
|
||||||
|
|
||||||
|
@ -911,7 +911,7 @@ static int cdns_reg_slave(struct i2c_client *slave)
|
||||||
if (slave->flags & I2C_CLIENT_TEN)
|
if (slave->flags & I2C_CLIENT_TEN)
|
||||||
return -EAFNOSUPPORT;
|
return -EAFNOSUPPORT;
|
||||||
|
|
||||||
ret = pm_runtime_get_sync(id->dev);
|
ret = pm_runtime_resume_and_get(id->dev);
|
||||||
if (ret < 0)
|
if (ret < 0)
|
||||||
return ret;
|
return ret;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue