mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-29 05:44:11 +00:00
Code Issues Releases Wiki Activity

pinctrl: actions: fix unsigned less than zero comparison

Browse source 
The check to see if platform_get_irq failed is performed on the
unsigned value of pctrl->irq[i] and the check is never true because
an unsigned cannot be less than zero.  Fix this by assinging the
signed int ret to the return of platform_get_irq and checking ret
instead.

Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0")

Fixes: 6c5d0736e9 ("pinctrl: actions: Add interrupt support for OWL S900 SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Colin Ian King 2018-07-02 13:47:08 +01:00 committed by Linus Walleij
parent 875a92b3f5
commit 23ee0f1920
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
drivers/pinctrl/actions/pinctrl-owl.c
View file

@ -1026,11 +1026,10 @@ int owl_pinctrl_probe(struct platform_device *pdev,
}
for (i = 0; i < pctrl->num_irq ; i++) {
pctrl->irq[i] = platform_get_irq(pdev, i);
if (pctrl->irq[i] < 0) {
ret = pctrl->irq[i];
ret = platform_get_irq(pdev, i);
if (ret < 0)
goto err_exit;
}
pctrl->irq[i] = ret;
}
ret = owl_gpio_init(pctrl);