mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-24 11:25:43 +00:00
Code Issues Releases Wiki Activity

arm64: dts: qcom: sc7180: Start the trogdor eDP/touchscreen regulator on

Browse source 
Now that we've added the `off-on-delay-us` for the touchpanel
regulator, we can see that we're actually hitting that delay at
bootup. I saw about 200 ms of delay.

Let's avoid that delay by starting the regulator on. We'll only do
this for eDP devices for the time being.

NOTE: we _won't_ do this for homestar. Homestar's panel really likes
to be power cycled. It's why the Linux driver for this panel has a
pm_runtime_put_sync_suspend() when the panel is being unprepared but
the normal panel-edp driver doesn't. It's also why this hardware has a
separate power rail for eDP vs. touchscreen, unlike all the other
trogdor boards. We won't start homestar's regulator on. While this
could mean a slight delay on homestar, it is probably a _correct_
delay. The bootloader might have left the regulator on (it does so in
dev and recovery modes), so if we turned the regulator off at probe
time and we actually hit the delay then we were probably violating T12
in the panel spec.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20221209091234.v3.3.I7050a61ba3a48e44b86053f265265b5e3c0cee31@changeid
This commit is contained in:
Douglas Anderson 2022-12-09 09:12:39 -08:00 committed by Bjorn Andersson
parent f5b4811e87
commit 23ff866987
3 changed files with 34 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar.dtsi
View file

@ -85,6 +85,24 @@ map1 {
};
};
/*
* ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES
*
* Sort order matches the order in the parent files (parents before children).
*/
&pp3300_dx_edp {
/*
* The atna33xc20 really likes to be power cycled to keep it from
* getting in a bad state. This is the reason that the touchscreen
* rail and eDP rails are separate from each other on homestar (but
* not other trogdor devices) Make sure it starts "off" at bootup.
*/
/delete-property/ regulator-boot-on;
};
/* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */
ap_ts_pen_1v8: &i2c4 {
status = "okay";
clock-frequency = <400000>;

8
arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi
View file

@ -34,6 +34,14 @@ pp3300_brij_ps8640: pp3300-brij-ps8640-regulator {
&pp3300_dx_edp {
off-on-delay-us = <500000>;
/*
* It's nicer to start with this regulator enabled. The
* bootloader may have left it on and it's nice not to cause an
* extra power cycle of the touchscreen and eDP panel at bootup.
* This should help speed bootup because we have off-on-delay-us.
*/
regulator-boot-on;
};
/* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */

8
arch/arm64/boot/dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi
View file

@ -15,6 +15,14 @@
&pp3300_dx_edp {
off-on-delay-us = <500000>;
/*
* It's nicer to start with this regulator enabled. The
* bootloader may have left it on and it's nice not to cause an
* extra power cycle of the touchscreen and eDP panel at bootup.
* This should help speed bootup because we have off-on-delay-us.
*/
regulator-boot-on;
};
/* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */