netfilter: nf_tables: Fix potential data-race in __nft_flowtable_type_get()
commit24225011d8
upstream. nft_unregister_flowtable_type() within nf_flow_inet_module_exit() can concurrent with __nft_flowtable_type_get() within nf_tables_newflowtable(). And thhere is not any protection when iterate over nf_tables_flowtables list in __nft_flowtable_type_get(). Therefore, there is pertential data-race of nf_tables_flowtables list entry. Use list_for_each_entry_rcu() to iterate over nf_tables_flowtables list in __nft_flowtable_type_get(), and use rcu_read_lock() in the caller nft_flowtable_type_get() to protect the entire type query process. Fixes:3b49e2e94e
("netfilter: nf_tables: add flow table netlink frontend") Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
f7e3c88cc2
commit
2485bcfe05
|
@ -7693,11 +7693,12 @@ static int nft_flowtable_parse_hook(const struct nft_ctx *ctx,
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* call under rcu_read_lock */
|
||||||
static const struct nf_flowtable_type *__nft_flowtable_type_get(u8 family)
|
static const struct nf_flowtable_type *__nft_flowtable_type_get(u8 family)
|
||||||
{
|
{
|
||||||
const struct nf_flowtable_type *type;
|
const struct nf_flowtable_type *type;
|
||||||
|
|
||||||
list_for_each_entry(type, &nf_tables_flowtables, list) {
|
list_for_each_entry_rcu(type, &nf_tables_flowtables, list) {
|
||||||
if (family == type->family)
|
if (family == type->family)
|
||||||
return type;
|
return type;
|
||||||
}
|
}
|
||||||
|
@ -7709,9 +7710,13 @@ nft_flowtable_type_get(struct net *net, u8 family)
|
||||||
{
|
{
|
||||||
const struct nf_flowtable_type *type;
|
const struct nf_flowtable_type *type;
|
||||||
|
|
||||||
|
rcu_read_lock();
|
||||||
type = __nft_flowtable_type_get(family);
|
type = __nft_flowtable_type_get(family);
|
||||||
if (type != NULL && try_module_get(type->owner))
|
if (type != NULL && try_module_get(type->owner)) {
|
||||||
|
rcu_read_unlock();
|
||||||
return type;
|
return type;
|
||||||
|
}
|
||||||
|
rcu_read_unlock();
|
||||||
|
|
||||||
lockdep_nfnl_nft_mutex_not_held();
|
lockdep_nfnl_nft_mutex_not_held();
|
||||||
#ifdef CONFIG_MODULES
|
#ifdef CONFIG_MODULES
|
||||||
|
|
Loading…
Reference in New Issue