mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 05:44:11 +00:00
scsi: ufs: Replace all non-returning strlcpy() with strscpy()
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Link: https://lore.kernel.org/r/20230530164131.987213-1-azeemshaikh38@gmail.com Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
41e5d6f64d
commit
2516cb8822
1 changed files with 1 additions and 1 deletions
|
@ -54,7 +54,7 @@ static int ufs_fault_set(const char *val, const struct kernel_param *kp)
|
|||
if (!setup_fault_attr(attr, (char *)val))
|
||||
return -EINVAL;
|
||||
|
||||
strlcpy(kp->arg, val, FAULT_INJ_STR_SIZE);
|
||||
strscpy(kp->arg, val, FAULT_INJ_STR_SIZE);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue