mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-14 04:26:45 +00:00
Btrfs: remove the code for the impossible case in cleanup_transaction()
If the transaction is removed from the transaction list, it means the transaction has been committed successfully. So it is impossible to call cleanup_transaction(), otherwise there is something wrong with the code logic. Thus, we use BUG_ON() instead of the original handle. Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
This commit is contained in:
parent
ac6738792f
commit
25d8c284c7
1 changed files with 6 additions and 5 deletions
|
@ -1450,11 +1450,12 @@ static void cleanup_transaction(struct btrfs_trans_handle *trans,
|
|||
|
||||
spin_lock(&root->fs_info->trans_lock);
|
||||
|
||||
if (list_empty(&cur_trans->list)) {
|
||||
spin_unlock(&root->fs_info->trans_lock);
|
||||
btrfs_end_transaction(trans, root);
|
||||
return;
|
||||
}
|
||||
/*
|
||||
* If the transaction is removed from the list, it means this
|
||||
* transaction has been committed successfully, so it is impossible
|
||||
* to call the cleanup function.
|
||||
*/
|
||||
BUG_ON(list_empty(&cur_trans->list));
|
||||
|
||||
list_del_init(&cur_trans->list);
|
||||
if (cur_trans == root->fs_info->running_transaction) {
|
||||
|
|
Loading…
Reference in a new issue