mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
[media] ddbridge: Do not free_irq() if request_irq() failed
My static checker detected that free_irq() is called even after request_irq() failed in ddb_probe(). In this case, the kernel may try to free dev->pdev->irq although the IRQ is not assigned. This event rarely occurs, but always introduces a warning if it happens. "goto fail1" always results in disabling enabled MSI and releasing a requested IRQ. It seems like the former handling is necessary. So I added a conditional branch before the free_irq() (stat == 0 means request_irq() succeeds). Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
parent
ee8defecea
commit
25e057fdde
1 changed files with 2 additions and 1 deletions
|
@ -1630,7 +1630,8 @@ static int ddb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
|
|||
printk(KERN_ERR "fail1\n");
|
||||
if (dev->msi)
|
||||
pci_disable_msi(dev->pdev);
|
||||
free_irq(dev->pdev->irq, dev);
|
||||
if (stat == 0)
|
||||
free_irq(dev->pdev->irq, dev);
|
||||
fail:
|
||||
printk(KERN_ERR "fail\n");
|
||||
ddb_unmap(dev);
|
||||
|
|
Loading…
Reference in a new issue