mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
udp: fix incorrect parameter validation in the udp_lib_getsockopt() function
[ Upstream commit4bb3ba7b74
] The 'len' variable can't be negative when assigned the result of 'min_t' because all 'min_t' parameters are cast to unsigned int, and then the minimum one is chosen. To fix the logic, check 'len' as read from 'optlen', where the types of relevant variables are (signed) int. Fixes:1da177e4c3
("Linux-2.6.12-rc2") Reviewed-by: Willem de Bruijn <willemb@google.com> Signed-off-by: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
393f4d390e
commit
2773d355f0
1 changed files with 2 additions and 2 deletions
|
@ -2792,11 +2792,11 @@ int udp_lib_getsockopt(struct sock *sk, int level, int optname,
|
|||
if (get_user(len, optlen))
|
||||
return -EFAULT;
|
||||
|
||||
len = min_t(unsigned int, len, sizeof(int));
|
||||
|
||||
if (len < 0)
|
||||
return -EINVAL;
|
||||
|
||||
len = min_t(unsigned int, len, sizeof(int));
|
||||
|
||||
switch (optname) {
|
||||
case UDP_CORK:
|
||||
val = udp_test_bit(CORK, sk);
|
||||
|
|
Loading…
Reference in a new issue