mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

tracing: Remove size restriction on synthetic event cmd error logging 

Currently, synthetic event command error strings are restricted to a
length of MAX_FILTER_STR_VAL (256), which is too short for some
commands already seen in the wild (with cmd strings longer than that
showing up truncated in err_log).

Remove the restriction so that no synthetic event command error string
is ever truncated.

Link: https://lkml.kernel.org/r/0376692396a81d0b795127c66ea92ca5bf60f481.1643399022.git.zanussi@kernel.org

Signed-off-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
This commit is contained in:
Tom Zanussi 2022-01-28 14:08:27 -06:00 committed by Steven Rostedt (Google)
parent edfeed318d
commit 27c888da98
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
kernel/trace/trace_events_synth.c
View File

@ -42,10 +42,13 @@ enum { ERRORS };
static const char *err_text[] = { ERRORS };
static char last_cmd[MAX_FILTER_STR_VAL];
static char *last_cmd;
static int errpos(const char *str)
{
if (!str || !last_cmd)
return 0;
return err_pos(last_cmd, str);
}
@ -54,11 +57,19 @@ static void last_cmd_set(const char *str)
if (!str)
return;
strncpy(last_cmd, str, MAX_FILTER_STR_VAL - 1);
kfree(last_cmd);
last_cmd = kzalloc(strlen(str) + 1, GFP_KERNEL);
if (!last_cmd)
return;
strncpy(last_cmd, str, strlen(str) + 1);
}
static void synth_err(u8 err_type, u8 err_pos)
static void synth_err(u8 err_type, u16 err_pos)
{
if (!last_cmd)
return;
tracing_log_err(NULL, "synthetic_events", last_cmd, err_text,
err_type, err_pos);
}