mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 23:27:06 +00:00
octeon_ep: cancel tx_timeout_task later in remove sequence
tx_timeout_task is canceled too early when removing the driver. Nothing
prevents .ndo_tx_timeout from triggering and queuing the work again.
Better cancel it after the netdev is unregistered.
It's harmless for octep_tx_timeout_task to run in the window between the
unregistration and cancelation, because it checks netif_running.
Fixes: 862cd659a6
("octeon_ep: Add driver framework and device initialization")
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Link: https://lore.kernel.org/r/20230810150114.107765-3-mschmidt@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
519b227904
commit
28458c8000
1 changed files with 1 additions and 1 deletions
|
@ -1200,12 +1200,12 @@ static void octep_remove(struct pci_dev *pdev)
|
|||
if (!oct)
|
||||
return;
|
||||
|
||||
cancel_work_sync(&oct->tx_timeout_task);
|
||||
cancel_work_sync(&oct->ctrl_mbox_task);
|
||||
netdev = oct->netdev;
|
||||
if (netdev->reg_state == NETREG_REGISTERED)
|
||||
unregister_netdev(netdev);
|
||||
|
||||
cancel_work_sync(&oct->tx_timeout_task);
|
||||
oct->poll_non_ioq_intr = false;
|
||||
cancel_delayed_work_sync(&oct->intr_poll_task);
|
||||
octep_device_cleanup(oct);
|
||||
|
|
Loading…
Reference in a new issue