mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-05 08:26:59 +00:00
Code Issues Releases Wiki Activity

blk-mq: cleanup blk_mq_rq_to_pdu()

Browse source 
Casting to void and adding the size of the request is "shit code" and
only a "crazy monkey on crack" would write that. So lets clean it up.

Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
Jens Axboe 2015-04-09 15:54:05 -06:00
parent c76cbbcf40
commit 2963e3f7e8
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/linux/blk-mq.h
View file

@ -230,7 +230,7 @@ void blk_mq_freeze_queue_start(struct request_queue *q);
/* /*
* Driver command data is immediately after the request. So subtract request * Driver command data is immediately after the request. So subtract request
* size to get back to the original request. * size to get back to the original request, add request size to get the PDU.
*/ */
static inline struct request *blk_mq_rq_from_pdu(void *pdu) static inline struct request *blk_mq_rq_from_pdu(void *pdu)
{ {
@ -238,7 +238,7 @@ static inline struct request *blk_mq_rq_from_pdu(void *pdu)
} }
static inline void *blk_mq_rq_to_pdu(struct request *rq) static inline void *blk_mq_rq_to_pdu(struct request *rq)
{ {
return (void *) rq + sizeof(*rq); return rq + 1;
} }
#define queue_for_each_hw_ctx(q, hctx, i) \ #define queue_for_each_hw_ctx(q, hctx, i) \