mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-30 22:26:55 +00:00
Code Issues Releases Wiki Activity

greybus: connection: prevent oops for protocol_id sysfs file

Browse source 
If we don't have a protocol assigned to a connection, don't oops when
trying to read the "protocol_id" sysfs file.

Fixes Jira SW-968.

Reported-by: Alexandre Bailon <abailon@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Greg Kroah-Hartman 2015-07-22 18:21:04 -07:00
parent 155b9f175e
commit 2975617421
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/staging/greybus/connection.c
View file

@ -80,7 +80,10 @@ protocol_id_show(struct device *dev, struct device_attribute *attr, char *buf)
{
struct gb_connection *connection = to_gb_connection(dev);
return sprintf(buf, "%d\n", connection->protocol->id);
if (connection->protocol)
return sprintf(buf, "%d\n", connection->protocol->id);
else
return -EINVAL;
}
static DEVICE_ATTR_RO(protocol_id);