modpost: refactor check_sec_ref()

We can replace &elf->sechdrs[i] with &sechdrs[i] to slightly shorten
the code because we already have the local variable 'sechdrs'.

However, defining 'sechdr' instead shortens the code further.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
This commit is contained in:
Masahiro Yamada 2023-10-08 02:04:47 +09:00
parent bd78c9d714
commit 29ae5c02ed
1 changed files with 7 additions and 6 deletions

View File

@ -1518,16 +1518,17 @@ static void section_rel(struct module *mod, struct elf_info *elf,
static void check_sec_ref(struct module *mod, struct elf_info *elf)
{
int i;
Elf_Shdr *sechdrs = elf->sechdrs;
/* Walk through all sections */
for (i = 0; i < elf->num_sections; i++) {
check_section(mod->name, elf, &elf->sechdrs[i]);
Elf_Shdr *sechdr = &elf->sechdrs[i];
check_section(mod->name, elf, sechdr);
/* We want to process only relocation sections and not .init */
if (sechdrs[i].sh_type == SHT_RELA)
section_rela(mod, elf, &elf->sechdrs[i]);
else if (sechdrs[i].sh_type == SHT_REL)
section_rel(mod, elf, &elf->sechdrs[i]);
if (sechdr->sh_type == SHT_RELA)
section_rela(mod, elf, sechdr);
else if (sechdr->sh_type == SHT_REL)
section_rel(mod, elf, sechdr);
}
}