mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-26 02:39:48 +00:00
Code Issues Releases Wiki Activity

spi: amd: Fix duplicate iounmap in error path

Browse source 
The AMD SPI driver uses devm_ioremap_resource() to map its registers, so
they're automatically unmapped via device_release() when the last ref on
the SPI controller is dropped.  The additional iounmap() in the ->probe()
error path is thus unnecessary.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/497cc38ae2beb7900ae05a1463eb83ff96e2770e.1588590210.git.lukas@wunner.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Lukas Wunner 2020-05-04 13:12:01 +02:00 committed by Mark Brown
parent b68527dfa9
commit 2b60c49f3c
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/spi/spi-amd.c
View file

@ -285,14 +285,12 @@ static int amd_spi_probe(struct platform_device *pdev)
err = spi_register_master(master);
if (err) {
dev_err(dev, "error %d registering SPI controller\n", err);
goto err_iounmap;
goto err_free_master;
}
platform_set_drvdata(pdev, amd_spi);
return 0;
err_iounmap:
iounmap(amd_spi->io_remap_addr);
err_free_master:
spi_master_put(master);