net/sched: cls_api: Initialize miss_cookie_node when action miss is not used
Function tcf_exts_init_ex() sets exts->miss_cookie_node ptr only
when use_action_miss is true so it assumes in other case that
the field is set to NULL by the caller. If not then the field
contains garbage and subsequent tcf_exts_destroy() call results
in a crash.
Ensure that the field .miss_cookie_node pointer is NULL when
use_action_miss parameter is false to avoid this potential scenario.
Fixes: 80cd22c35c
("net/sched: cls_api: Support hardware miss to tc action")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230420183634.1139391-1-ivecera@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
7041101ff6
commit
2cc8a008d6
|
@ -3211,6 +3211,7 @@ int tcf_exts_init_ex(struct tcf_exts *exts, struct net *net, int action,
|
||||||
#ifdef CONFIG_NET_CLS_ACT
|
#ifdef CONFIG_NET_CLS_ACT
|
||||||
exts->type = 0;
|
exts->type = 0;
|
||||||
exts->nr_actions = 0;
|
exts->nr_actions = 0;
|
||||||
|
exts->miss_cookie_node = NULL;
|
||||||
/* Note: we do not own yet a reference on net.
|
/* Note: we do not own yet a reference on net.
|
||||||
* This reference might be taken later from tcf_exts_get_net().
|
* This reference might be taken later from tcf_exts_get_net().
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in New Issue