mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
iio: imu: kmx61: Balance runtime pm + use pm_runtime_resume_and_get()
No point in calling pm_runtime_put_noidle() that isn't balancing a get. Note no actual impact because the runtime pm core protects against a negative reference counter. For the pm_runtime_resume_and_get() main interest is in clearing out this old pattern to avoid it getting coppied into new submissions. Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Link: https://lore.kernel.org/r/20210509113354.660190-10-jic23@kernel.org
This commit is contained in:
parent
19611aec50
commit
2d082b6ed2
1 changed files with 1 additions and 4 deletions
|
@ -750,7 +750,7 @@ static int kmx61_set_power_state(struct kmx61_data *data, bool on, u8 device)
|
|||
}
|
||||
|
||||
if (on) {
|
||||
ret = pm_runtime_get_sync(&data->client->dev);
|
||||
ret = pm_runtime_resume_and_get(&data->client->dev);
|
||||
} else {
|
||||
pm_runtime_mark_last_busy(&data->client->dev);
|
||||
ret = pm_runtime_put_autosuspend(&data->client->dev);
|
||||
|
@ -759,8 +759,6 @@ static int kmx61_set_power_state(struct kmx61_data *data, bool on, u8 device)
|
|||
dev_err(&data->client->dev,
|
||||
"Failed: kmx61_set_power_state for %d, ret %d\n",
|
||||
on, ret);
|
||||
if (on)
|
||||
pm_runtime_put_noidle(&data->client->dev);
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
@ -1426,7 +1424,6 @@ static int kmx61_remove(struct i2c_client *client)
|
|||
|
||||
pm_runtime_disable(&client->dev);
|
||||
pm_runtime_set_suspended(&client->dev);
|
||||
pm_runtime_put_noidle(&client->dev);
|
||||
|
||||
if (client->irq > 0) {
|
||||
iio_triggered_buffer_cleanup(data->acc_indio_dev);
|
||||
|
|
Loading…
Reference in a new issue