mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 21:33:52 +00:00
net: hns3: modify an unsuitable print when setting unknown duplex to fibre
Currently, if device is in link down status and user uses 'ethtool -s' command to set speed but not specify duplex mode, the duplex mode passed from ethtool to driver is unknown value(255), and the fibre port will identify this value as half duplex mode and print "only copper port supports half duplex!". This message is confusing. So for fibre port, only the setting duplex is half, prints error and returns. Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
e99f8e7f88
commit
2d3db26d78
1 changed files with 1 additions and 1 deletions
|
@ -736,7 +736,7 @@ static int hns3_check_ksettings_param(const struct net_device *netdev,
|
|||
if (ops->get_media_type)
|
||||
ops->get_media_type(handle, &media_type, &module_type);
|
||||
|
||||
if (cmd->base.duplex != DUPLEX_FULL &&
|
||||
if (cmd->base.duplex == DUPLEX_HALF &&
|
||||
media_type != HNAE3_MEDIA_TYPE_COPPER) {
|
||||
netdev_err(netdev,
|
||||
"only copper port supports half duplex!");
|
||||
|
|
Loading…
Reference in a new issue