mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 04:47:05 +00:00
scsi: libsas: Fix use-after-free bug in smp_execute_task_sg()
[ Upstream commit46ba53c306
] When executing SMP task failed, the smp_execute_task_sg() calls del_timer() to delete "slow_task->timer". However, if the timer handler sas_task_internal_timedout() is running, the del_timer() in smp_execute_task_sg() will not stop it and a UAF will happen. The process is shown below: (thread 1) | (thread 2) smp_execute_task_sg() | sas_task_internal_timedout() ... | del_timer() | ... | ... sas_free_task(task) | kfree(task->slow_task) //FREE| | task->slow_task->... //USE Fix by calling del_timer_sync() in smp_execute_task_sg(), which makes sure the timer handler have finished before the "task->slow_task" is deallocated. Link: https://lore.kernel.org/r/20220920144213.10536-1-duoming@zju.edu.cn Fixes:2908d778ab
("[SCSI] aic94xx: new driver") Reviewed-by: Jason Yan <yanaijie@huawei.com> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
c74b3d46d8
commit
2e12ce270f
1 changed files with 1 additions and 1 deletions
|
@ -67,7 +67,7 @@ static int smp_execute_task_sg(struct domain_device *dev,
|
|||
res = i->dft->lldd_execute_task(task, GFP_KERNEL);
|
||||
|
||||
if (res) {
|
||||
del_timer(&task->slow_task->timer);
|
||||
del_timer_sync(&task->slow_task->timer);
|
||||
pr_notice("executing SMP task failed:%d\n", res);
|
||||
break;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue