mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 00:39:48 +00:00
batman-adv: Place kref_get for neigh_ifinfo near use
It is hard to understand why the refcnt is increased when it isn't done near the actual place the new reference is used. So using kref_get right before the place which requires the reference and in the same function helps to avoid accidental problems caused by incorrect reference counting. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
This commit is contained in:
parent
23f5548559
commit
2e774ac2f7
1 changed files with 1 additions and 1 deletions
|
@ -460,9 +460,9 @@ batadv_neigh_ifinfo_new(struct batadv_neigh_node *neigh,
|
|||
|
||||
INIT_HLIST_NODE(&neigh_ifinfo->list);
|
||||
kref_init(&neigh_ifinfo->refcount);
|
||||
kref_get(&neigh_ifinfo->refcount);
|
||||
neigh_ifinfo->if_outgoing = if_outgoing;
|
||||
|
||||
kref_get(&neigh_ifinfo->refcount);
|
||||
hlist_add_head_rcu(&neigh_ifinfo->list, &neigh->ifinfo_list);
|
||||
|
||||
out:
|
||||
|
|
Loading…
Reference in a new issue