mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 05:44:11 +00:00
selftests: forwarding: Fix layer 2 miss test flakiness
[ Upstream commit93590849a0
] After enabling a multicast querier on the bridge (like the test is doing), the bridge will wait for the Max Response Delay before starting to forward according to its MDB in order to let Membership Reports enough time to be received and processed. Currently, the test is waiting for exactly the default Max Response Delay (10 seconds) which is racy and leads to failures [1]. Fix by reducing the Max Response Delay to 1 second. [1] [...] # TEST: L2 miss - Multicast (IPv4) [FAIL] # Unregistered multicast filter was hit after adding MDB entry Fixes:8c33266ae2
("selftests: forwarding: Add layer 2 miss test cases") Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Hangbin Liu <liuhangbin@gmail.com> Acked-by: Nikolay Aleksandrov <razor@blackwall.org> Link: https://lore.kernel.org/r/20240208155529.1199729-2-idosch@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
dcaf06afaa
commit
2fc52eb636
1 changed files with 6 additions and 2 deletions
|
@ -209,14 +209,17 @@ test_l2_miss_multicast()
|
|||
# both registered and unregistered multicast traffic.
|
||||
bridge link set dev $swp2 mcast_router 2
|
||||
|
||||
# Set the Max Response Delay to 100 centiseconds (1 second) so that the
|
||||
# bridge will start forwarding according to its MDB soon after a
|
||||
# multicast querier is enabled.
|
||||
ip link set dev br1 type bridge mcast_query_response_interval 100
|
||||
|
||||
# Forwarding according to MDB entries only takes place when the bridge
|
||||
# detects that there is a valid querier in the network. Set the bridge
|
||||
# as the querier and assign it a valid IPv6 link-local address to be
|
||||
# used as the source address for MLD queries.
|
||||
ip link set dev br1 type bridge mcast_querier 1
|
||||
ip -6 address add fe80::1/64 nodad dev br1
|
||||
# Wait the default Query Response Interval (10 seconds) for the bridge
|
||||
# to determine that there are no other queriers in the network.
|
||||
sleep 10
|
||||
|
||||
test_l2_miss_multicast_ipv4
|
||||
|
@ -224,6 +227,7 @@ test_l2_miss_multicast()
|
|||
|
||||
ip -6 address del fe80::1/64 dev br1
|
||||
ip link set dev br1 type bridge mcast_querier 0
|
||||
ip link set dev br1 type bridge mcast_query_response_interval 1000
|
||||
bridge link set dev $swp2 mcast_router 1
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue