mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-18 00:24:39 +00:00
ath10k: fix division by zero in send path
commita006acb931
upstream. Add the missing endpoint max-packet sanity check to probe() to avoid division by zero in ath10k_usb_hif_tx_sg() in case a malicious device has broken descriptors (or when doing descriptor fuzz testing). Note that USB core will reject URBs submitted for endpoints with zero wMaxPacketSize but that drivers doing packet-size calculations still need to handle this (cf. commit2548288b4f
("USB: Fix: Don't skip endpoint descriptors with maxpacket=0")). Fixes:4db66499df
("ath10k: add initial USB support") Cc: stable@vger.kernel.org # 4.14 Cc: Erik Stromdahl <erik.stromdahl@gmail.com> Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20211027080819.6675-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2b94d10056
commit
3110371c7a
1 changed files with 5 additions and 0 deletions
|
@ -865,6 +865,11 @@ static int ath10k_usb_setup_pipe_resources(struct ath10k *ar,
|
|||
le16_to_cpu(endpoint->wMaxPacketSize),
|
||||
endpoint->bInterval);
|
||||
}
|
||||
|
||||
/* Ignore broken descriptors. */
|
||||
if (usb_endpoint_maxp(endpoint) == 0)
|
||||
continue;
|
||||
|
||||
urbcount = 0;
|
||||
|
||||
pipe_num =
|
||||
|
|
Loading…
Reference in a new issue