mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 02:19:51 +00:00
USB: serial: iuu_phoenix: remove redundant variable 'error'
The variable error is initialized to 0 and is set to 1 this value is never read as it is on an immediate return path. The only read of error is to check it is 0 and this check is always true at that point of the code. The variable is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
parent
764de1059b
commit
315e2811f5
1 changed files with 1 additions and 3 deletions
|
@ -643,7 +643,6 @@ static void iuu_uart_read_callback(struct urb *urb)
|
|||
struct iuu_private *priv = usb_get_serial_port_data(port);
|
||||
unsigned long flags;
|
||||
int status = urb->status;
|
||||
int error = 0;
|
||||
int len = 0;
|
||||
unsigned char *data = urb->transfer_buffer;
|
||||
priv->poll++;
|
||||
|
@ -660,12 +659,11 @@ static void iuu_uart_read_callback(struct urb *urb)
|
|||
if (urb->actual_length > 1) {
|
||||
dev_dbg(&port->dev, "%s - urb->actual_length = %i\n", __func__,
|
||||
urb->actual_length);
|
||||
error = 1;
|
||||
return;
|
||||
}
|
||||
/* if len > 0 call readbuf */
|
||||
|
||||
if (len > 0 && error == 0) {
|
||||
if (len > 0) {
|
||||
dev_dbg(&port->dev, "%s - call read buf - len to read is %i\n",
|
||||
__func__, len);
|
||||
status = iuu_read_buf(port, len);
|
||||
|
|
Loading…
Reference in a new issue