mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
mtd: nand: denali: add missing nand_release() call in denali_remove()
Unregister the NAND device from the NAND subsystem when removing a denali
NAND controller, otherwise the MTD attached to the NAND device is still
exposed by the MTD layer, and accesses to this device will likely crash
the system.
Fixes: 2a0a288ec2
("mtd: denali: split the generic driver and PCI layer")
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
This commit is contained in:
parent
207f6582dd
commit
320092a05d
1 changed files with 9 additions and 2 deletions
|
@ -1622,9 +1622,16 @@ EXPORT_SYMBOL(denali_init);
|
|||
/* driver exit point */
|
||||
void denali_remove(struct denali_nand_info *denali)
|
||||
{
|
||||
/*
|
||||
* Pre-compute DMA buffer size to avoid any problems in case
|
||||
* nand_release() ever changes in a way that mtd->writesize and
|
||||
* mtd->oobsize are not reliable after this call.
|
||||
*/
|
||||
int bufsize = denali->mtd.writesize + denali->mtd.oobsize;
|
||||
|
||||
nand_release(&denali->mtd);
|
||||
denali_irq_cleanup(denali->irq, denali);
|
||||
dma_unmap_single(denali->dev, denali->buf.dma_buf,
|
||||
denali->mtd.writesize + denali->mtd.oobsize,
|
||||
dma_unmap_single(denali->dev, denali->buf.dma_buf, bufsize,
|
||||
DMA_BIDIRECTIONAL);
|
||||
}
|
||||
EXPORT_SYMBOL(denali_remove);
|
||||
|
|
Loading…
Reference in a new issue