mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 09:50:04 +00:00
clk: meson: use devm_of_clk_add_hw_provider
There is no remove callbacks in meson's clock controllers and of_clk_del_provider is never called if of_clk_add_hw_provider has been executed, introducing a potential memory leak. Fixing this by the using the devm variant. In reality, the leak would never happen since these controllers are never unloaded once in use ... still, this is worth cleaning. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
This commit is contained in:
parent
323346d31d
commit
332b32a232
3 changed files with 7 additions and 6 deletions
|
@ -854,8 +854,8 @@ static int axg_clkc_probe(struct platform_device *pdev)
|
|||
}
|
||||
}
|
||||
|
||||
return of_clk_add_hw_provider(dev->of_node, of_clk_hw_onecell_get,
|
||||
clkc_data->hw_onecell_data);
|
||||
return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
|
||||
clkc_data->hw_onecell_data);
|
||||
}
|
||||
|
||||
static struct platform_driver axg_driver = {
|
||||
|
|
|
@ -2002,8 +2002,9 @@ static int gxbb_clkc_probe(struct platform_device *pdev)
|
|||
goto iounmap;
|
||||
}
|
||||
|
||||
return of_clk_add_hw_provider(dev->of_node, of_clk_hw_onecell_get,
|
||||
clkc_data->hw_onecell_data);
|
||||
|
||||
return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
|
||||
clkc_data->hw_onecell_data);
|
||||
|
||||
iounmap:
|
||||
iounmap(clk_base);
|
||||
|
|
|
@ -878,8 +878,8 @@ static int meson8b_clkc_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
}
|
||||
|
||||
return of_clk_add_hw_provider(dev->of_node, of_clk_hw_onecell_get,
|
||||
&meson8b_hw_onecell_data);
|
||||
return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
|
||||
&meson8b_hw_onecell_data);
|
||||
}
|
||||
|
||||
static const struct of_device_id meson8b_clkc_match_table[] = {
|
||||
|
|
Loading…
Reference in a new issue