mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 06:33:07 +00:00
mtd: spear_smi: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Acked-by: Tudor Ambarus <tudor.ambarus@linaro.org> Link: https://lore.kernel.org/linux-mtd/20231008200143.196369-8-u.kleine-koenig@pengutronix.de
This commit is contained in:
parent
56b877dc5f
commit
3401446fa4
1 changed files with 2 additions and 4 deletions
|
@ -1031,7 +1031,7 @@ static int spear_smi_probe(struct platform_device *pdev)
|
|||
*
|
||||
* free all allocations and delete the partitions.
|
||||
*/
|
||||
static int spear_smi_remove(struct platform_device *pdev)
|
||||
static void spear_smi_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct spear_smi *dev;
|
||||
struct spear_snor_flash *flash;
|
||||
|
@ -1048,8 +1048,6 @@ static int spear_smi_remove(struct platform_device *pdev)
|
|||
/* clean up mtd stuff */
|
||||
WARN_ON(mtd_device_unregister(&flash->mtd));
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_PM_SLEEP
|
||||
|
@ -1095,7 +1093,7 @@ static struct platform_driver spear_smi_driver = {
|
|||
.pm = &spear_smi_pm_ops,
|
||||
},
|
||||
.probe = spear_smi_probe,
|
||||
.remove = spear_smi_remove,
|
||||
.remove_new = spear_smi_remove,
|
||||
};
|
||||
module_platform_driver(spear_smi_driver);
|
||||
|
||||
|
|
Loading…
Reference in a new issue