mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
bpf: fix precision propagation verbose logging
Fix wrong order of frame index vs register/slot index in precision
propagation verbose (level 2) output. It's wrong and very confusing as is.
Fixes: 529409ea92
("bpf: propagate precision across all frames, not just the last one")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20230313184017.4083374-1-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This commit is contained in:
parent
49b5300f1f
commit
34f0677e7a
1 changed files with 2 additions and 2 deletions
|
@ -15068,7 +15068,7 @@ static int propagate_precision(struct bpf_verifier_env *env,
|
||||||
!(state_reg->live & REG_LIVE_READ))
|
!(state_reg->live & REG_LIVE_READ))
|
||||||
continue;
|
continue;
|
||||||
if (env->log.level & BPF_LOG_LEVEL2)
|
if (env->log.level & BPF_LOG_LEVEL2)
|
||||||
verbose(env, "frame %d: propagating r%d\n", i, fr);
|
verbose(env, "frame %d: propagating r%d\n", fr, i);
|
||||||
err = mark_chain_precision_frame(env, fr, i);
|
err = mark_chain_precision_frame(env, fr, i);
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
return err;
|
return err;
|
||||||
|
@ -15084,7 +15084,7 @@ static int propagate_precision(struct bpf_verifier_env *env,
|
||||||
continue;
|
continue;
|
||||||
if (env->log.level & BPF_LOG_LEVEL2)
|
if (env->log.level & BPF_LOG_LEVEL2)
|
||||||
verbose(env, "frame %d: propagating fp%d\n",
|
verbose(env, "frame %d: propagating fp%d\n",
|
||||||
(-i - 1) * BPF_REG_SIZE, fr);
|
fr, (-i - 1) * BPF_REG_SIZE);
|
||||||
err = mark_chain_precision_stack_frame(env, fr, i);
|
err = mark_chain_precision_stack_frame(env, fr, i);
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
return err;
|
return err;
|
||||||
|
|
Loading…
Reference in a new issue