mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 15:47:36 +00:00
staging: vme_user: Fix possible UAF in tsi148_dma_list_add
Smatch report warning as follows:
drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add() warn:
'&entry->list' not removed from list
In tsi148_dma_list_add(), the error path "goto err_dma" will not
remove entry->list from list->entries, but entry will be freed,
then list traversal may cause UAF.
Fix by removeing it from list->entries before free().
Fixes: b2383c90a9
("vme: tsi148: fix first DMA item mapping")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221117035914.2954454-1-cuigaosheng1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
ccdbe14b77
commit
357057ee55
1 changed files with 1 additions and 0 deletions
|
@ -1751,6 +1751,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
|
|||
return 0;
|
||||
|
||||
err_dma:
|
||||
list_del(&entry->list);
|
||||
err_dest:
|
||||
err_source:
|
||||
err_align:
|
||||
|
|
Loading…
Reference in a new issue