mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 21:33:52 +00:00
hwmon: (scpi-hwmon) shows the negative temperature properly
[ Upstream commit 78d1355234
]
The scpi hwmon shows the sub-zero temperature in an unsigned integer,
which would confuse the users when the machine works in low temperature
environment. This shows the sub-zero temperature in an signed value and
users can get it properly from sensors.
Signed-off-by: Riwen Lu <luriwen@kylinos.cn>
Tested-by: Xin Chen <chenxin@kylinos.cn>
Link: https://lore.kernel.org/r/20210604030959.736379-1-luriwen@kylinos.cn
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
8ea34be15f
commit
35b651d6bd
1 changed files with 9 additions and 0 deletions
|
@ -99,6 +99,15 @@ scpi_show_sensor(struct device *dev, struct device_attribute *attr, char *buf)
|
|||
|
||||
scpi_scale_reading(&value, sensor);
|
||||
|
||||
/*
|
||||
* Temperature sensor values are treated as signed values based on
|
||||
* observation even though that is not explicitly specified, and
|
||||
* because an unsigned u64 temperature does not really make practical
|
||||
* sense especially when the temperature is below zero degrees Celsius.
|
||||
*/
|
||||
if (sensor->info.class == TEMPERATURE)
|
||||
return sprintf(buf, "%lld\n", (s64)value);
|
||||
|
||||
return sprintf(buf, "%llu\n", value);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue