mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
net: stmmac: dwmac-dwc-qos-eth: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
f4d05c4197
commit
360cd89064
1 changed files with 2 additions and 4 deletions
|
@ -464,7 +464,7 @@ static int dwc_eth_dwmac_probe(struct platform_device *pdev)
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int dwc_eth_dwmac_remove(struct platform_device *pdev)
|
static void dwc_eth_dwmac_remove(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
struct net_device *ndev = platform_get_drvdata(pdev);
|
struct net_device *ndev = platform_get_drvdata(pdev);
|
||||||
struct stmmac_priv *priv = netdev_priv(ndev);
|
struct stmmac_priv *priv = netdev_priv(ndev);
|
||||||
|
@ -477,8 +477,6 @@ static int dwc_eth_dwmac_remove(struct platform_device *pdev)
|
||||||
data->remove(pdev);
|
data->remove(pdev);
|
||||||
|
|
||||||
stmmac_remove_config_dt(pdev, priv->plat);
|
stmmac_remove_config_dt(pdev, priv->plat);
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static const struct of_device_id dwc_eth_dwmac_match[] = {
|
static const struct of_device_id dwc_eth_dwmac_match[] = {
|
||||||
|
@ -490,7 +488,7 @@ MODULE_DEVICE_TABLE(of, dwc_eth_dwmac_match);
|
||||||
|
|
||||||
static struct platform_driver dwc_eth_dwmac_driver = {
|
static struct platform_driver dwc_eth_dwmac_driver = {
|
||||||
.probe = dwc_eth_dwmac_probe,
|
.probe = dwc_eth_dwmac_probe,
|
||||||
.remove = dwc_eth_dwmac_remove,
|
.remove_new = dwc_eth_dwmac_remove,
|
||||||
.driver = {
|
.driver = {
|
||||||
.name = "dwc-eth-dwmac",
|
.name = "dwc-eth-dwmac",
|
||||||
.pm = &stmmac_pltfr_pm_ops,
|
.pm = &stmmac_pltfr_pm_ops,
|
||||||
|
|
Loading…
Reference in a new issue