mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 08:08:54 +00:00
nvme: don't return an error from nvme_configure_metadata
When a fabrics controller claims to support an invalidate metadata configuration we already warn and disable metadata support. No need to also return an error during revalidation. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Reviewed-by: Daniel Wagner <dwagner@suse.de> Tested-by: Kanchan Joshi <joshi.k@samsung.com>
This commit is contained in:
parent
bb49c6fa8b
commit
363f636860
1 changed files with 5 additions and 8 deletions
|
@ -1723,7 +1723,7 @@ static int nvme_setup_streams_ns(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int nvme_configure_metadata(struct nvme_ns *ns, struct nvme_id_ns *id)
|
static void nvme_configure_metadata(struct nvme_ns *ns, struct nvme_id_ns *id)
|
||||||
{
|
{
|
||||||
struct nvme_ctrl *ctrl = ns->ctrl;
|
struct nvme_ctrl *ctrl = ns->ctrl;
|
||||||
|
|
||||||
|
@ -1739,7 +1739,8 @@ static int nvme_configure_metadata(struct nvme_ns *ns, struct nvme_id_ns *id)
|
||||||
|
|
||||||
ns->features &= ~(NVME_NS_METADATA_SUPPORTED | NVME_NS_EXT_LBAS);
|
ns->features &= ~(NVME_NS_METADATA_SUPPORTED | NVME_NS_EXT_LBAS);
|
||||||
if (!ns->ms || !(ctrl->ops->flags & NVME_F_METADATA_SUPPORTED))
|
if (!ns->ms || !(ctrl->ops->flags & NVME_F_METADATA_SUPPORTED))
|
||||||
return 0;
|
return;
|
||||||
|
|
||||||
if (ctrl->ops->flags & NVME_F_FABRICS) {
|
if (ctrl->ops->flags & NVME_F_FABRICS) {
|
||||||
/*
|
/*
|
||||||
* The NVMe over Fabrics specification only supports metadata as
|
* The NVMe over Fabrics specification only supports metadata as
|
||||||
|
@ -1747,7 +1748,7 @@ static int nvme_configure_metadata(struct nvme_ns *ns, struct nvme_id_ns *id)
|
||||||
* remap the separate metadata buffer from the block layer.
|
* remap the separate metadata buffer from the block layer.
|
||||||
*/
|
*/
|
||||||
if (WARN_ON_ONCE(!(id->flbas & NVME_NS_FLBAS_META_EXT)))
|
if (WARN_ON_ONCE(!(id->flbas & NVME_NS_FLBAS_META_EXT)))
|
||||||
return -EINVAL;
|
return;
|
||||||
|
|
||||||
ns->features |= NVME_NS_EXT_LBAS;
|
ns->features |= NVME_NS_EXT_LBAS;
|
||||||
|
|
||||||
|
@ -1774,8 +1775,6 @@ static int nvme_configure_metadata(struct nvme_ns *ns, struct nvme_id_ns *id)
|
||||||
else
|
else
|
||||||
ns->features |= NVME_NS_METADATA_SUPPORTED;
|
ns->features |= NVME_NS_METADATA_SUPPORTED;
|
||||||
}
|
}
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static void nvme_set_queue_limits(struct nvme_ctrl *ctrl,
|
static void nvme_set_queue_limits(struct nvme_ctrl *ctrl,
|
||||||
|
@ -1916,9 +1915,7 @@ static int nvme_update_ns_info(struct nvme_ns *ns, struct nvme_id_ns *id)
|
||||||
ns->lba_shift = id->lbaf[lbaf].ds;
|
ns->lba_shift = id->lbaf[lbaf].ds;
|
||||||
nvme_set_queue_limits(ns->ctrl, ns->queue);
|
nvme_set_queue_limits(ns->ctrl, ns->queue);
|
||||||
|
|
||||||
ret = nvme_configure_metadata(ns, id);
|
nvme_configure_metadata(ns, id);
|
||||||
if (ret)
|
|
||||||
goto out_unfreeze;
|
|
||||||
nvme_set_chunk_sectors(ns, id);
|
nvme_set_chunk_sectors(ns, id);
|
||||||
nvme_update_disk_info(ns->disk, ns, id);
|
nvme_update_disk_info(ns->disk, ns, id);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue