mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 01:49:36 +00:00
[media] tuners/xc4000: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
f01e0ffd01
commit
36628731ec
1 changed files with 1 additions and 1 deletions
|
@ -1066,7 +1066,7 @@ static int check_firmware(struct dvb_frontend *fe, unsigned int type,
|
|||
goto fail;
|
||||
}
|
||||
|
||||
memcpy(&priv->cur_fw, &new_fw, sizeof(priv->cur_fw));
|
||||
priv->cur_fw = new_fw;
|
||||
|
||||
/*
|
||||
* By setting BASE in cur_fw.type only after successfully loading all
|
||||
|
|
Loading…
Reference in a new issue