mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-29 23:53:32 +00:00
Code Issues Releases Wiki Activity

drm/sun4i: dw-hdmi: always set clock rate

Browse source 
As expected, HDMI controller clock should always match pixel clock. In
the past, changing HDMI controller rate would seemingly worsen
situation. However, that was the result of other bugs which are now
fixed.

Fix that by removing set_rate quirk and always set clock rate.

Fixes: 40bb9d3147 ("drm/sun4i: Add support for H6 DW HDMI controller")
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Tested-by: Andre Heider <a.heider@gmail.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210209175900.7092-4-jernej.skrabec@siol.net
This commit is contained in:
Jernej Skrabec 2021-02-09 18:58:58 +01:00 committed by Maxime Ripard
parent 50791f5d7b
commit 36b53581fe
No known key found for this signature in database
GPG key ID: E3EF0D6F671851C5
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
View file

@ -21,8 +21,7 @@ static void sun8i_dw_hdmi_encoder_mode_set(struct drm_encoder *encoder,
{ {
struct sun8i_dw_hdmi *hdmi = encoder_to_sun8i_dw_hdmi(encoder); struct sun8i_dw_hdmi *hdmi = encoder_to_sun8i_dw_hdmi(encoder);
if (hdmi->quirks->set_rate) clk_set_rate(hdmi->clk_tmds, mode->crtc_clock * 1000);
clk_set_rate(hdmi->clk_tmds, mode->crtc_clock * 1000);
} }
static const struct drm_encoder_helper_funcs static const struct drm_encoder_helper_funcs
@ -295,7 +294,6 @@ static int sun8i_dw_hdmi_remove(struct platform_device *pdev)
static const struct sun8i_dw_hdmi_quirks sun8i_a83t_quirks = { static const struct sun8i_dw_hdmi_quirks sun8i_a83t_quirks = {
.mode_valid = sun8i_dw_hdmi_mode_valid_a83t, .mode_valid = sun8i_dw_hdmi_mode_valid_a83t,
.set_rate = true,
}; };
static const struct sun8i_dw_hdmi_quirks sun50i_h6_quirks = { static const struct sun8i_dw_hdmi_quirks sun50i_h6_quirks = {

1
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
View file

@ -179,7 +179,6 @@ struct sun8i_dw_hdmi_quirks {
enum drm_mode_status (*mode_valid)(struct dw_hdmi *hdmi, void *data, enum drm_mode_status (*mode_valid)(struct dw_hdmi *hdmi, void *data,
const struct drm_display_info *info, const struct drm_display_info *info,
const struct drm_display_mode *mode); const struct drm_display_mode *mode);
unsigned int set_rate : 1;
unsigned int use_drm_infoframe : 1; unsigned int use_drm_infoframe : 1;
}; };